Fixed Invalid add-on zip files from add-on builder

[Xon]

Affected version

2.0.10

Using winrar;


Using Windows 10 zip support;

 

[Xon]

Fixed by editing XF/Service/AddOn/ReleaseBuilder with

$localName = substr($file->getPathname(), strlen($this->buildRoot));

To;

$localName = substr($file->getPathname(), strlen($this->buildRoot) + 1);

This removes the leading \ (well /)

 

[DragonByte Tech]

This problem doesn’t appear to affect macOS using The Unarchived, as I generated & unzipped a few Addons yesterday after upgrading to 2.0.10.


Fillip

 

[Xon]

Windows 10 built in zip extractor doesn't like it.

 

[Snog]

I'm not seeing it in Windows 7.

 

[Xon]

Might just be Windows 10 support then

 

[Snog]

Just had a user that is using Windows 10 report an empty zip file that was compiled today with XF 2.0.10.

It's fine with Linux and Windows 7.

I applied the fix @Xon suggested and am waiting for feedback if it works for the user.

 

[au lait]

I also confirm this error. Only since the latest XF version. I use Windows 7

 

[Snog]

And I can confirm the fix @Xon suggested works. The user that had the problem reports that all is fine after downloading the zip created with the patched ReleaseBuilder file. And I'm still able to unzip it in Linux without a problem.

 

[Chris D]

I’ll apply it shortly and test it with an add on release I’m doing. That’ll make sure it still works on macOS too.

 

[DragonByte Tech]

Works for me on the latest High Sierra, both in The Unarchiver and in Archive Utility


Fillip

 

[XF Bug Bot]

Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in the next XF release (2.0.11).

Change log:

Fix an issue which affects building add-on releases on Windows where local paths included a leading slash.

 

[Lukas W.]

As this is quite interrupting, would you mind to share the fix with us before the next update @Chris D so we can manually apply it in the meantime?

 

[Snog]

As this is quite interrupting, would you mind to share the fix with us before the next update @Chris D so we can manually apply it in the meantime?

https://xenforo.com/community/threa...files-from-add-on-builder.153536/post-1280817

 

[Lukas W.]

https://xenforo.com/community/threa...files-from-add-on-builder.153536/post-1280817

That sure is one fix, I'm asking if it's the official though.

 

[Chris D]

There were other, non-related changes, so yes, just use that fix for now.

 

[Lukas W.]

I've applied the fix from above to my installation and packaged up the add-ons once more. They look fine in my windows installation, but my colleagues report them broken still when extracting them on Mac. If the fix from above is the one that got implemented, you probably want to look into it once more.

 

[Lukas W.]

That's what the contents of the zip looks like on Mac. The same zip file is fine on Windows, where it was built.

 

[Chris D]

I need to do some further testing, but this should sort it:

$localName = str_replace('\\', '/', substr($file->getPathname(), strlen($this->buildRoot) + 1));

The directory separator in the world of Zip files should always be / but the path name will use \ on Windows.

 

[truonglv]

Hello @Chris D

Does this issue has been addressed? I have use 2.0.10 but someone still report to me that cannot open the compress file.