Fixed Inline code not working correctly

[Chris D]

Yeah.

Bear in mind we were already using a version of the patch to this method in 2.2.12:

Fixed - Editor insertSpoiler does not correctly handle formatting

When using the 'insert spoiler' (and bb-code which uses wrapSelectionText) this can result in unexpectedly broken bb-code. Given this bb-code in the rich-text editor: line1 line2 line3 line4 Drag-select line2/line3, and select insert spoiler. This will result in the following html: line1

xenforo.com

So we already have the inline argument and that is already set to true on the inline tags.

 

[Chris D]

So code in XF 2.2.12 is basically this:

Fixed - Editor insertSpoiler does not correctly handle formatting

When using the 'insert spoiler' (and bb-code which uses wrapSelectionText) this can result in unexpectedly broken bb-code. Given this bb-code in the rich-text editor: line1 line2 line3 line4 Drag-select line2/line3, and select insert spoiler. This will result in the following html: line1

xenforo.com

 

[Xon]

I'm wondering if an updated version of Froala is breaking the code I linked to

So we already have the inline argument and that is already set to true on the inline tags.

Hmm. I think the difference between the snippet I shared and the current version is when inline is false it unwraps any <p> tags. I've shared via a conversation the code I've got being loaded on my own site which appears to have resolved this issue.

 

[Xon]

ed.html.getSelected is a buggy mess and behaves differently depending on the browser.

This had been fixed in a previous version of Froala. Apparently there was a regression!

 

[Chris D]

I think this is mostly fixed for the next release. Thanks @Xon.