Fixed Inconsistent variable in "account_avatar" and "account_avatar_overlay"

[xfrocks]

In XenForo_ControllerPublic_Account::actionAvatar, there are these lines:

$gravatarEmail = $visitor['gravatar'] ? $visitor['gravatar'] : $visitor['email'];

$viewParams = array(
...
'gravatarEmail'=> $gravatarEmail,
...
);

But the variable is not used at all in template "account_avatar". It is used once in "account_avatar_overlay" though. I think they should be used in the same way in these two templates.

 

[Mike]

$gravatarEmail is the correct one as it's more consistent with the behavior that we use.

 

[xfrocks]

$gravatarEmail is the correct one as it's more consistent with the behavior that we use.

So account_avatar will use $gravatarEmail for the input field right?

 

[Mike]

Correct.