1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Inconsistent variable in "account_avatar" and "account_avatar_overlay"

Discussion in 'Resolved Bug Reports' started by xfrocks, Oct 24, 2013.

  1. xfrocks

    xfrocks Well-Known Member

    In XenForo_ControllerPublic_Account::actionAvatar, there are these lines:

    PHP:
    $gravatarEmail $visitor['gravatar'] ? $visitor['gravatar'] : $visitor['email'];

    $viewParams = array(
    ...
    'gravatarEmail'=> $gravatarEmail,
    ...
    );
    But the variable is not used at all in template "account_avatar". It is used once in "account_avatar_overlay" though. I think they should be used in the same way in these two templates.
     
  2. Mike

    Mike XenForo Developer Staff Member

    $gravatarEmail is the correct one as it's more consistent with the behavior that we use.
     
  3. xfrocks

    xfrocks Well-Known Member

    So account_avatar will use $gravatarEmail for the input field right?
     
  4. Mike

    Mike XenForo Developer Staff Member

    Correct.
     
    xfrocks likes this.

Share This Page