1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

As Designed Inconsistent Resource Activity

Discussion in 'Resource Manager Resolved Bugs' started by Jeremy, May 17, 2013.

  1. Jeremy

    Jeremy XenForo Moderator Staff Member

    Sometimes displays viewing a resource, sometimes it doesn't. Not sure exact reproce cases, but it's happening here.

    Attached Files:

  2. The Forum Heroes

    The Forum Heroes Well-Known Member

    Maybe it is coded somewhere if resources = 0 hide?
  3. Chris D

    Chris D XenForo Developer Staff Member

    Oh wait... you mean it's displaying:

    "Viewing resource" versus "Viewing resource <resource name>"
    Andrej and xenUnity like this.
  4. Brogan

    Brogan XenForo Moderator Staff Member

    It's the same for the tab on the profile page.

    Edit: I originally thought it was referring to the resource count but after Chris' edit I now see it's related to the resource being viewed.
  5. Chris D

    Chris D XenForo Developer Staff Member

    I think the simple answer is, I wasn't viewing a resource.

    I was on the resource index.

    The getSessionActivityDetailsForList function in the Resource controller checks the current activity params for a resource ID. If there isn't one (such as being on the resource index) or you don't have permission to view the resource then the phrase returned is simply "Viewing resource".
    Jeremy likes this.
  6. Jeremy

    Jeremy XenForo Moderator Staff Member

    Yeah, sorry guys, was on the phone. Phrase duplication seems slightly off here to me.
    (And I apologize to Mike for the vague report. I personally hate those when I get 'em.)
  7. Mike

    Mike XenForo Developer Staff Member

    Chris's analysis is correct - we could potentially try to do more detailed analysis in the future, though the code may not totally support it (I'd have to check). I'd recommend suggesting that if it's important.
  8. xf_phantom

    xf_phantom Well-Known Member

    It wasn't useless IMO:p
    It is inconsistent, that messages, likes etc is shown, even the user has 0
    But resources is shown only if the count is >1
  9. Jeremy

    Jeremy XenForo Moderator Staff Member

    Its not that important (AKA, I'll forget about it for a while until I notice it again).

Share This Page