Type hinting on cleanUpInvalidRecords & filterViewableUnapprovedItems are inconsistent with out methods

X

Xon

Well-known member
Affected version
2.3.6
filterViewableUnapprovedItems should be type hinting AbstractCollection<ApprovalQueue> not ArrayCollection

cleanUpInvalidRecords should be hinted as AbstractCollection<ApprovalQueue>. This will throw some type conflicts with the current array type hint, so maybe adding AbstractCollection<ApprovalQueue>|ApprovalQueue[] or using iterable<ApprovalQueue>
 

Similar threads

X
Fixed Reliable type hinting when using AbstractCollection/ArrayCollection/FinderCollection collections
Replies
17
Views
521
TickTackk
TickTackk
M
Inconsistent function return type hinting
Replies
0
Views
31
mattrogowski
M
X
Fixed \XF::extendClass type hinting doesn't match \XF\Extension::extendClass
Replies
1
Views
537
XF Bug Bot
XF Bug Bot
X
Fixed No return type hinting on Controller noPermission/notFound
Replies
1
Views
921
XF Bug Bot
XF Bug Bot
Back
Top Bottom