Inconsistent function return type hinting

M

mattrogowski

Well-known member
Licensed customer
Affected version
2.3.3
XF\Entity\UserUpgrade::setupApiResultData() has a return type of void, but XF\Mvc\Entity\Entity::setupApiResultData() doesn't and neither do seemingly most other entity classes. It means that any addons that extend XF\Entity\UserUpgrade::setupApiResultData() will break as it's arbitrarily had a return type added.

I can see that XF\Entity\UserUpgrade only had this function added in 2.3.0 Beta 4 so I presume it was an IDE autocomplete or something. It would be better if it was either added to all of them or none of them.
 

Similar threads

X
Fixed Type hinting on cleanUpInvalidRecords & filterViewableUnapprovedItems are inconsistent with out methods
Replies
1
Views
78
XF Bug Bot
XF Bug Bot
X
Fixed Reliable type hinting when using AbstractCollection/ArrayCollection/FinderCollection collections
Replies
17
Views
523
TickTackk
TickTackk
DragonByte Tech
Fixed Incorrect return type hint for \XF\Mvc\Entity\Manager::findByIds
Replies
1
Views
59
XF Bug Bot
XF Bug Bot
X
Fixed \XF::asVisitor should use phpdoc template for return type hint.
Replies
1
Views
79
XF Bug Bot
XF Bug Bot
X
Fixed \XF::extendClass type hinting doesn't match \XF\Extension::extendClass
Replies
1
Views
537
XF Bug Bot
XF Bug Bot
Back
Top Bottom