Resource icon

Ignore Signatures 2.2

No permission to download
Overview Updates (10) Reviews (7) History Discussion
Edrondol said:
Disabled it and it no longer loads a new page. I'm on 1.1.4.
Click to expand...

That could be the issue. I've only tested this on 1.1.5, and for me it works fine now :/

I know this is probably asking a lot, but could you try it on a 1.1.5 install?

Scratch that, I just remembered my dev install is still 1.1.4 ;)

The only thing I can think of is another addon is clashing with mine and producing this result...

(someone probably forgot to call the parent!)

I'll look into it :)
 
One other thing this did was to stop uploaded attachments from embedding. Instead it just said "attachment xxxxx". Once I disabled this was fixed. Again, could be a 1.1.4 issue.
 
Edrondol said:
One other thing this did was to stop uploaded attachments from embedding. Instead it just said "attachment xxxxx". Once I disabled this was fixed. Again, could be a 1.1.4 issue.
Click to expand...

It's more likely the JSon and other AJAX features aren't loading correctly. I did stop overriding the insert jSon function, but to make the addon still work I had to add some code to it.

I did then call the parent, but if another addon exists that doesn't call the parent, then the original code will never be executed.
 
Okaaay, this is very strange!

If I call the parent in the view class I'm overriding, the image attachments don't show. If I don't call the parent, they show...

Any ideas? Maybe @xf_phantom or someone? I'll ask the rest of the xF community...
 
Liam W said:
I'll look into it. But I don't think I'm getting it, so it could be tricky...

EDIT: Ok, this is happening to me. Looking into it...
Click to expand...

At first glance, it seems to be working ok now. Interesting side effect, the Hide Users Signature link inside the signature now disappears if your mouse isn't hovering over the signature.
 
Rambro said:
At first glance, it seems to be working ok now. Interesting side effect, the Hide Users Signature link inside the signature now disappears if your mouse isn't hovering over the signature.
Click to expand...

Nope, that's a new feature introduced in 1.3 :)

It's designed so the link is less obtrusive. If you don't wan't it, just remove the css requirement from the template.
 
Liam W said:
Nope, that's a new feature introduced in 1.3 :)

It's designed so the link is less obtrusive. If you don't wan't it, just remove the css requirement from the template.
Click to expand...

Its cool with me. I just didn't see it in the update so I thought it might have been a side effect. Obviously there though, so, whoops!
 
Liam W said:
Hmm, it shouldn't be - it doesn't seem to have that effect on my forum at least. Let me check...
Click to expand...

I'll disable everything else to double check but disabling this addon restored the save draft function that was missing.


Edit: Save Draft is still missing from the editor with this addon being the only active one.
 
Last edited:
TeflonDon said:
I'll disable everything else to double check but disabling this addon restored the save draft function that was missing.


Edit: Save Draft is still missing from the editor with this addon being the only active one.
Click to expand...

Ok, just confirmed it. That was the bad news. The good news? I've also fixed it :D

Packaging new version, expect it to be uploaded by 02:25 :)
 
You must log in or register to reply here.

Similar threads

AndyB
Force ignore [Paid]
Replies
0
Views
18
AndyB
AndyB
L
  • Question Question
XF 2.3 Add option to hide or ignore other users’ profile pictures
Replies
5
Views
37
Alvin63
A
Ozzy47
[OzzModz] Force Ignore [Deleted]
Replies
4
Views
91
Ozzy47
Ozzy47
frm
  • Question Question
XF 2.3 Signatures with "dofollow" links
Replies
0
Views
29
frm
frm
dima1987
How should the "Ignore" function work?
Replies
0
Views
32
dima1987
dima1987
Back
Top Bottom