1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Editor doesn't copy colors

Discussion in 'Resolved Bug Reports' started by rellect, May 19, 2014.

  1. rellect

    rellect Well-Known Member

    When copying a text (within the editor) with color, the color doesn't copied.

    screencast.gif
     
    Adam Howard and Veer like this.
  2. Brogan

    Brogan XenForo Moderator Staff Member

    I believe this may be as designed as some formatting is deliberately removed such as colours and font sizes.

    I'll leave it to Mike to confirm though.
     
    Chris D likes this.
  3. Chris D

    Chris D XenForo Developer Staff Member

    Indeed.

    The fact that colours were copied was also an often reported bug.

    Think of the scenario where a site has a light style and a dark style and text copy pasted by a user of the light style maybe invisible to users of the dark style and vice versa.

    Not to mention any text copied from any other site that may not work with the currently enabled style.
     
    SneakyDave likes this.
  4. Brogan

    Brogan XenForo Moderator Staff Member

  5. Adam Howard

    Adam Howard Well-Known Member

    @rellect What did you use to make that gif?

    I ask because it maybe useful for others reporting bugs in the future. :)
     
  6. Chris D

    Chris D XenForo Developer Staff Member

    There are a lot of those apps.

    I've been using LICEcap. http://www.cockos.com/licecap/

    It's my personal favourite as it works on Windows and Mac OS X.
     
    Adam Howard likes this.
  7. Mike

    Mike XenForo Developer Staff Member

    It does work if you have more than one line selected. Looks like that's because the code that detected the paste was from redactor required a <div> tag to have the extra attribute. I've now applied that in a few other cases to try to catch this situation.
     
    Liam W, Adam Howard and Chris D like this.
  8. rellect

    rellect Well-Known Member

    Have you applied the fix here? I can still reproduce it.
    There's something related that I want to report, but need to make sure if it's not resolved by this fix.
     
    Adam Howard likes this.
  9. Mike

    Mike XenForo Developer Staff Member

    I've just rolled out the fix for this now.
     
    Adam Howard likes this.
  10. Adam Howard

    Adam Howard Well-Known Member

  11. ENF

    ENF Well-Known Member

    Works fine for me.

    Copy of this colored text is shown below.

    this colored text

    (FF 28.0, 29.o.1)
     
    Last edited: May 28, 2014
  12. Martok

    Martok Well-Known Member

    Tested using @Adam Howard's test post. Didn't work for me using Chrome on Android (Nexus 7).
     
  13. Mike

    Mike XenForo Developer Staff Member

    As noted, colors (and various other things) are only maintained if you copy from within the editor. If you are copying from anywhere else, heavy filtering will be applied to the pasted text.
     
    SneakyDave likes this.
  14. Adam Howard

    Adam Howard Well-Known Member

    Was copying from within the editor using

    Google Chrome Version 35.0.1916.114
    Ubuntu 14.04 LTS
     
  15. Adam Howard

    Adam Howard Well-Known Member

    Never mind, it's working now.... @Martok try clearing your temp files, cache, and cookies
     

Share This Page