1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Lack of Interest Details of Warning Phrase

Discussion in 'Closed Suggestions' started by Amaury, Jul 13, 2015.

  1. Amaury

    Amaury Well-Known Member

    This isn't exactly a bug per se, but I'm reporting it more for aesthetic and (sort of) consistency reasons.

    While it makes sense grammatically, it just sounds a bit weird to me. Warning Details sounds better and is consistent with Warning Points.

    KHF Warning 1.PNG

    KHF Warning 2.PNG

    The phrase is details_of_warning. Although if this ends up being worthy of a fix, the phrase title should also be changed to warning_details. It's only used in the warning_info template, so it should only take about 10-15 seconds to change the phrase title, phrase text, and the phrase title in the template. :)

    <dl class="ctrlUnit">
            <dt>{xen:phrase details_of_warning}:</dt>
                <xen:if is="{$warning.notes}"><div class="muted">{xen:helper bodytext, $warning.notes}</div></xen:if>
    Like with everything else of this nature that I've reported, whether it was fixed or not, I know you can easily change phrases to your liking, but still.
    Xon likes this.
  2. imthebest

    imthebest Formerly Super120

    This isn't a bug at all. I think you should have posted this in the Suggestions forum.
  3. Amaury

    Amaury Well-Known Member

  4. imthebest

    imthebest Formerly Super120

    I know I know but this one is different (I believe) because you are suggesting to also change the name of the phrase.

    Anyway the devs have the last word here as you said.
  5. Amaury

    Amaury Well-Known Member

    It's not really a suggestion. That's simply so the phrase name will be consistent with the change if this ends up getting changed.
  6. MirandaSings

    MirandaSings Active Member

    I also agree that it should be changed. Or maybe even change it to Warn/Warned user.
    Last edited by a moderator: Jul 14, 2015
  7. Amaury

    Amaury Well-Known Member

    That doesn't really make sense. Warning details is the title of the warning, not whether or not the user was warned, though I see how it can be confusing. As such, for our own site, we customized the warning_info template a little:

    KHF Warning.PNG
  8. Mr Lucky

    Mr Lucky Well-Known Member

    Details of Warning sounds better to me than Warning Details
    Last edited: Jul 14, 2015
  9. Chris D

    Chris D XenForo Developer Staff Member

    I have moved this to Suggestions, for now.

    As you acknowledged, this isn't a bug per se, and it's not exactly inconsistent, either. Very much appears, even based on the feedback in the thread, that this is mostly down to personal preference.
    Amaury likes this.

Share This Page