• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

CodeMirror PHP mode is broken in ACP

Affected version
2.0.1 - 2.0.2

CMTV

Active member
#1
Hi!

Put the code below in any admin template (for example in addon_list):
HTML:
<xf:codeeditorrow mode="php" data-line-wrapping="true" class="codeEditor--autoSize" />
This code creates code editor row without any errors:
php_mode.png

But the code is not highlighting and throws an error when hitting "Enter":
php_mode_error.png

I think this error happens because of the incorrect mode calls order. "clike" mode should be loaded first and only after that "php" mode should be loaded. So I tried to change the order in CodeLanguage class:
PHP:
//
// Before:
// 'php',
// 'clike'
//
// Now:
'php' => [
    'modes' => [
        'clike',
        'php'
    ],
    'mime' => 'text/x-php',
    'common' => true
],
I did not notice any errors and the editor is even making automatic tabulation but still no highlighting...
modified.png

Moreover, function has a cm-variable class but it must has cm-keyword class so there is something working completely wrong with mode="php"...

Other modes (html, javascript) are working fine:
html_is_working_fine.png


UPD 1: tried to change cm-variable class to cm-keyword. The word was highlighted correctly so everything is okay with LESS/CSS side.
 
Last edited: