1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Bug in the alerts

Discussion in 'Resolved Bug Reports' started by seabeds, Aug 19, 2015.

  1. seabeds

    seabeds Active Member

    I am on xF 1.5

    When a user comments on your status, it will say "User commented on 's post on your profile." which doesn't make sense.
     
  2. Chris D

    Chris D XenForo Developer Staff Member

    That doesn't appear to be the case here:
    upload_2015-8-19_21-57-14.png

    When you upgraded did you have any outdated templates or phrases? If so, was one of them related to this particular alert?

    It could theoretically be caused by incorrect data being stored with the alert or incorrect data being passed to the template from the alert handler, but really that would only happen if there were files missing/not updated or an add-on was involved.

    Please try to replicate the issue on the default XF style (create a new style with no parent to try this properly), and with add-ons disabled. If an add-on is involved, you may need to disable all add-ons and then try to trigger the alert again.
     
  3. seabeds

    seabeds Active Member

    I believe it has to do with the template since there was an outdated one. Do you happen to know which template it would be? I don't know which one status alerts would be under. There were actually a few templates that were outdated and I think i did them all wrong.
     
  4. Chris D

    Chris D XenForo Developer Staff Member

    That particular one would be alert_profile_post_comment_your_profile

    You may be able to see a list of them in Admin CP > Appearance > Customized Components
     
  5. Amaury

    Amaury Well-Known Member

    @Chris D, I don't really have any reproduction steps, but this has happened on our forum as well and I have some information that may help!

    Making sure it wasn't a style issue, I tested it on the default style as well just to be sure, and it appears to be only with comments that were made before updating to 1.5. Everything still works properly and you get linked to the correct profile post, the phrasing is just broken.

    Comment from when we were still on 1.4.9, before updating to 1.5.0:

    KHF Alert 1.PNG

    KHF Alert 2.PNG

    Comment after updating to 1.5.0:

    KHF Alert 3.PNG

    KHF Alert 4.PNG

    (Took me a while to figure how to comment and such in order to get that phrasing, haha!)

    While the first and third screenshots are the Alerts page, perhaps it's something to do with the fact that comments didn't show up on the news feed before.
     
    Last edited: Aug 20, 2015
    seabeds likes this.
  6. seabeds

    seabeds Active Member

    Yes, after looking and digging around I too noticed that the phrasing was before the update (or during... a bit confusing)
     
  7. Chris D

    Chris D XenForo Developer Staff Member

    Thanks for the confirmation.

    We're going to try and workaround this, but, of course, it is a rather temporary issue. Any new alerts in 1.5 will work correctly, it's just the old ones that will look odd.
     
    tufan, Eagle, seabeds and 2 others like this.
  8. clove28

    clove28 Active Member

    I think this is related with this bug. I'm receiving alert but nothing is showing..

    upload_2015-8-28_9-7-38.png
     
  9. Martok

    Martok Well-Known Member

    There was an issue with blank alerts a while ago that I think at the time was related to uninstalling Tapatalk. See this thread and how it was fixed (master data reimported) in case it is similar.

    XF 1.2 - Blank Alerts
     
    Chris D likes this.
  10. Chris D

    Chris D XenForo Developer Staff Member

    Yeah. Definitely not related to this.

    Though it could also be missing or corrupt templates so try in the XF unedited default style and try rebuilding master data.
     
  11. clove28

    clove28 Active Member

    I uninstalled Tapatalk last year and this problem started after upgrading to 1.5

    Even with the default style, it's still occurring. How can I rebuild the master data? Thanks! :)
     
  12. Brogan

    Brogan XenForo Moderator Staff Member

    clove28 likes this.
  13. clove28

    clove28 Active Member

  14. Chris D

    Chris D XenForo Developer Staff Member

    Ok. We need to ascertain via the db what these alerts are.

    Right click on one of the blank alerts, and click Inspect Element. The empty alert should have a container which is an <li> element. That element will have an ID like alert-1234. The numerical part is the alert ID.

    Now run this database query:

    SELECT * FROM xf_user_alert WHERE alert_id = 1234

    (Where 1234 is the actual alert ID).


    The important bits of info there are the content_id and action. What are they?
     
  15. clove28

    clove28 Active Member

    Hi Chris, thank you for your response. Could you teach me how to execute that command through terminal command? I already got the alert ID.
     
  16. Chris D

    Chris D XenForo Developer Staff Member

    You'd usually use PhpMyAdmin if available. If not, then you would likely need to execute "mysql" followed by:

    USE <db name>;

    (Replace <db name> with you XF database name)

    The run:

    SELECT * FROM xf_user_alert WHERE alert_id = 1234;


    (The semi colon is likely required at the end of each query).

    If you still have problems or you are unsure, submit a ticket from your customer area with all of he relevant log in details and I'll take a closer look for you.
     
  17. clove28

    clove28 Active Member

    Hi Cris,

    Here's the result..

    upload_2015-8-29_7-12-50.png
     
  18. Chris D

    Chris D XenForo Developer Staff Member

    That is tag_comment. I actually meant to ask you for the content type but I'm pretty sure the content type will be profile_post.

    Which means, something weird has happened. I would hazard a guess that one of the files hasn't uploaded correctly or you've had or got an add on that is overriding the behaviour.

    In XF 1.5 the correct content type would be profile_post comment and the correct action would be simply tag. (I think).

    Could you run a file health check in Admin CP > Tools > File Health Check?

    Any problems there?
     
  19. clove28

    clove28 Active Member

    Yes there are but they are add-ons related..

    Code:
    Potential Problems
    library/Waindigo/Listener/TemplatePostRender.php
    File does not contain expected contents.
    
    library/WMTech/DoublePost/ControllerPublic/Thread.php
    File does not contain expected contents.
    
    library/MinPostLengthEnforcer/DataWriter/DiscussionMessage/Post.php
    File does not contain expected contents.
     
  20. Chris D

    Chris D XenForo Developer Staff Member

    Ok. Can you submit a ticket from your customer area and provide log in details for your Admin CP, PhpMyAdmin and FTP please?

    I will look at this myself but it might not be until later today.
     

Share This Page