Ads Manager 2 by Siropu [Paid] 2.5.8

[NealC]

Hello @Siropu - I just upgraded my forum (rvforums.com) from xf 2.2 (latest) to 2.3.6. None of my styles are showing google ads now, seems the custom html script code didn't migrate over.

I upgraded your add-on to the latest after the 2.3.6 from 2.2.x upgrade.

I have 4 other sites to be upgraded which are now on hold. The xf 2.2 sites are using your add-on version 2.4.22, the site I upgraded this morning has your add-on version of 2.5.8.

Please check the upgrade path from 2.4.22 to 2.5.x to ensure no data loss please.

 

[NealC]

The script is showing in the database, it ends up loading slowly for some reason. Google ads don't appear to be rending in my styles for some reason, not sure if the script code is being blocked. I don't use ad blockers, I always see the ads on my site.

Edit: I see an error in the chrome dev tools:

tagerror: adsbygoogle.push() error: no slot size for availablewidth=0

RVForums.com

The best RV forum discussion community on the web. Welcome to your virtual RV campground with the friendliest people discussing RV's, motorhomes, travel trailers, fifth wheels, toy haulers, popups, Class A, Class B, Class C, Super C, camping destinations, travel planning, campgrounds, RV...

rvforums.com

 

[NealC]

I'm getting this resolved so ignore my posts above. However, I do notice that the Custom HTML tab content doesn't seem to load unless I click into the box. You may want to look into that @Siropu

 

[NealC]

Still can't get ads to work due to the error below. I have a custom CSS in extra.less embedded in my ad code which worked in 2.2. Not sure why this isn't working in 2.3.6.

Error:

tagerror: adsbygoogle.push() error: no slot size for availablewidth=0

My ad code:

<script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-xxxxxxx1111111"
crossorigin="anonymous"></script>
<!-- Horizontal 970x90 -->
<ins class="adsbygoogle custhorizontal"
style="display:inline-block;"
data-ad-client="ca-pub-xxxxxx111111"
data-ad-slot="xxxxx11111"></ins>
<script>
(adsbygoogle = window.adsbygoogle || []).push({});
</script>

Extra.less has the following class referenced above:

.custhorizontal { width:100%;max-width: 970px !important; height: 90px !important; margin:0 auto; }
@media (max-width: @xf-responsiveMedium)
{
.custhorizontal {max-width: 100% !important; max-height: 90px !important; margin:0 auto; }
}

 

[NealC]

@Siropu I wonder if your ads add-on is rending before the page is loaded and that's causing the issue? My css class isn't available yet?

Also, I just tried enabling lazy loading and that's not persisting. I come back and it's not checked.

Looking forward to getting this working ASAP as I'm losing advertising exposure. My ads on https://rvforums.com should be like on my other site https://flightinfo.com which is on hold at xf 2.2 until this is resolved.

 

[Siropu]

I wonder if your ads add-on is rending before the page is loaded and that's causing the issue? My css class isn't available yet?

No. Try adding in the inline css setting of the ad or package: width: 100%;

 

[NealC]

No. Try adding in the inline css setting of the ad or package: width: 100%;

I can't do inline as I use a media query. I restrict the size on desktop and mobile differently as google ads wants to place monster ads in if I don't. Worked fine on xf2.2 and your 2.2 supported add-on.

 

[Siropu]

The change I suggested changes the width of the container not of the adsense ad itself.

 

[NealC]

I need to control the height too. On mobile they'll use large rectangular ads.

Why did my css class work on 2.2 and not 2.3?

 

[Siropu]

Why did my css class work on 2.2 and not 2.3?

I think container used to have width 100% that's why I suggested to make that change.

 

[NealC]

Still fiddling with this, not sure why the change, would be nice to put it back the way it was so you don't break ads.

 

[Siropu]

Still fiddling with this

Have you tried the change I suggested?

 

[NealC]

Have you tried the change I suggested?

I tried everything I could think of, no luck. Could you kindly provide CSS you suggest to restore this like it was before so I can try what you're suggesting?

 

[Siropu]

Could you kindly provide CSS you suggest to restore this like it was before so I can try what you're suggesting?

.samCodeUnit .samItem, .samBannerUnit .samItem
{
    width: 100%;
}

 

[NealC]

.samCodeUnit .samItem, .samBannerUnit .samItem
{
    width: 100%;
}

Thanks, still not working on my iPhone view of the site.

 

[NealC]

It broke it on the PC/Chrome view too, reverting to the partial fix I had. Sad this worked perfectly in 2.2 and your add-on for 2.2 and now it's hard broke.

 

[Siropu]

Try this instead:

.samCodeUnit, .samBannerUnit, .samItem
{
    width: 100% !important;
}

 

[NealC]

Try this instead:

.samCodeUnit, .samBannerUnit, .samItem
{
    width: 100% !important;
}

No change. After your initial post I wrapped the ad in a div with the width:100% including !important attempts. Still not working on iPhone for some reason. I'll keep digging into it.

On a different note, a suggestion:

You have the Devices tab in creating/editing an ad. Obviously the devices are broad these days and that's very hard to rely on. I was looking at it to break my ad up for desktop vs. mobile but I think the only way to really handle it is via media queries.

As in xf 12.3.6 with variations, maybe consider ad variations in an ad placement? Maybe a media queries tab so that media queries can be selected or added and ad variations created within each media query?

 

[Siropu]

After your initial post I wrapped the ad in a div with the width:100% including !important attempts.

It already has two container divs. If you have added the code above and you still get that adsense error, it's strange.

You have the Devices tab in creating/editing an ad. Obviously the devices are broad these days and that's very hard to rely on.

Mobile phones, tablet and desktop should cover everything, no need to select individual brands.

 

[NealC]

Mobile phones, tablet and desktop should cover everything, no need to select individual brands.

To elaborate on my suggestion on variations like xf 2.3's styles: Allow me to have multiple ads setup for an ad placement that vary based on form factor or other params but my main interest is media queries (devices). Maybe I have an ad "below breadcrumbs" and I want one google ad code for PC and another for mobile, etc. etc. Yeah, I could and currently have to create multiple ad placements and there is high risk multiple could show in a slot if I can't combine them into one with rules.