Fixed AdminCP menu oddities when scrolling

[DragonByte Tech]

Affected version

2.0.4

The left side menu in the AdminCP goes haywire when you have a lot of entries and you scroll up and down again:

https://www.dropbox.com/s/w1h8akafyy49b8j/xf2-sidebar.mov?dl=0


Fillip

 

[Lukas W.]

Probably similar to these ones:

• First
• Second

This is a haunting bug!

 

[Lukas W.]

I'm throwing in another one of these. When having a long list of add-ons and at least one add-on that has a pending upgrade, scrolling down causes the navigation to spasm out of place as well:

To view this content we will need your consent to set third party cookies.
For more detailed information, see our cookies page.

Accept third party cookies

 

[Lukas W.]

One more: Having a lot of debug output (on a cron job page, haven't verified if it happens everywhere) also messes up the navigation clipping: https://my.mixtape.moe/bvmjyp.mp4

 

[btmgreg]

I experienced this myself today. It wasn't necessarily the addons page, but admincp in general. Sorry for the bump!

 

[Mike]

I think some of these may be internal issues with the StickyKit library we use. Unfortunately, we need functionality beyond the standard position: sticky CSS, so we do need custom JS. I suspect in the future, we may be able to ditch the library and use some more modern browser features (position sticky and intersection observers, I think) to achieve this effect in such a way that hopefully doesn't trigger issues like this. However, given that it seems to happen quite infrequently and it probably does need a whole new approach to fix, I'm not sure we're likely to focus on this for a while. Short of just closing this as a "won't fix" after all this time, I think I'll move it to future fix.

 

[Starbucks]

I think some of these may be internal issues with the StickyKit library we use. Unfortunately, we need functionality beyond the standard position: sticky CSS, so we do need custom JS. I suspect in the future, we may be able to ditch the library and use some more modern browser features (position sticky and intersection observers, I think) to achieve this effect in such a way that hopefully doesn't trigger issues like this. However, given that it seems to happen quite infrequently and it probably does need a whole new approach to fix, I'm not sure we're likely to focus on this for a while. Short of just closing this as a "won't fix" after all this time, I think I'll move it to future fix.

Hey @Mike,

It's me from the future!
Any update about this?

Thanks!

 

[Jeremy P]

I believe this is addressed in XF 2.3 by virtue of using browser-native sticky handling.