[XenMods] Announcements [Deleted]

[kankan]

It is better, but some display issues. See attached file.

 

[Daniel Hood]

<?php
class PHCannouncements_Model_Threads extends XenForo_Model
{
    function Announcements()
    {
        $ThreadModel = XenForo_Model::create('XenForo_Model_Thread');
        $ForumModel = XenForo_Model::create('XenForo_Model_Forum');
        $_getThreads = $this->_getDb()->fetchAll("SELECT thread.thread_id as thread_id, thread.node_id
            FROM xf_thread as thread
            WHERE thread.sticky = 2
            ORDER BY thread.last_post_date DESC"
        );
       
        $Threads = array();
       
        for ($i = 0; $i < count($_getThreads); $i++)
        {
            $Forum = $ForumModel->getForumById($_getThreads[$i]['node_id']);
            if (is_array($Forum))
            {            
                $Thread = $ThreadModel->prepareThread($ThreadModel->getThreadById($_getThreads[$i]['thread_id'], array('join' => 17)), $Forum);
                $Thread['canInlineMod'] = false;
                $Thread['canEditThread'] = false;
                $Threads[] = $Thread;
            }
        }
       
       
        return $Threads;
    }
    function Stickies()
    {        
        $ThreadModel = XenForo_Model::create('XenForo_Model_Thread');
        $ForumModel = XenForo_Model::create('XenForo_Model_Forum');
       
        $_getThreads = $this->_getDb()->fetchAll("SELECT thread.thread_id as thread_id, thread.node_id
            FROM xf_thread as thread
            WHERE thread.sticky = 1
            ORDER BY thread.last_post_date DESC"
        );
       
        $Threads = array();
       
        for ($i = 0; $i < count($_getThreads); $i++)
        {
           
            $Forum = $ForumModel->getForumById($_getThreads[$i]['node_id']);
            if (is_array($Forum))
            {            
                $Thread = $ThreadModel->prepareThread($ThreadModel->getThreadById($_getThreads[$i]['thread_id'], array('join' => 17)), $Forum);
                $Thread['canInlineMod'] = false;
                $Thread['canEditThread'] = false;
                $Threads[] = $Thread;
            }
        }
       
       
        return $Threads;
    }
}

Try this as file: /upload/library/PHCannouncements/Model/Threads.php

 

[kankan]

looks better. See attached file

 

[Daniel Hood]

My bad, didn't include the css in the xml file. You're going to have to reinstall the new package I put up in a minute (if you want you can just use the xml as that's the only thing that changed for you but the fix that we've been discussing for your other error is being included also)

 

[Daniel Hood]

Daniel Hood updated PHP Help Center Announcements with a new update entry:

CSS Fix & Node no longer existing Fix

The css file for the admin page wasn't included in the old xml file. If there was an invalid node for a stickied thread the admin panel page errored. Both of things are now fixed.

Read the rest of this update entry...

 

[kankan]

Thank you Daniel, it is working.
Any way to move the block, as displayed in the attached screen ?

 

[Daniel Hood]

You want it at the bottom?

 

[kankan]

Yes under the 2 XenPorta blocks

 

[Daniel Hood]

Yes but you have to find the template hook you want to use (look at the forum_list_nodes template and find xen:hook). Once you find which one you want to use go to:

/upload/library/PHCannouncements/listeners/Hook.php

change

if ($hookName == 'forum_list_nodes' || $hookName == 'forum_view_pagenav_before')

to the hook names you want to use (forum_view_pagenav_before) is when you click on a node.

 

[kankan]

Thanks for your support. I will check in this way.

 

[Daniel Hood]

Let me know if you can't find it and I'll try to look too. I just don't have those addons/blocks installed.

 

[Daniel Hood]

And thank you for your feedback on the addon, I never would have known it wasn't working for people.

 

[Cambion]

@Daniel Hood
(First thank you for this. I've been looking around forever for a feature like this. It is so annoying when you want to have an important thread in ALL FORUMS and can't. So this add-on is great so thank you for making it)

My questions are

1. I skimmed through the posts in this thread so this may have been answered already but is this compatible with 1.2?

2. I read somewhere in this thread that there was some issues with Post Ratings add-on and USername rich everywhere? I use both of these add-ons so would i be able to use yours without any issues.

3. With the updated version you just added today, do I need to do any of the manual edits that you suggested the other user above do ?

Thanks so much.

 

[Daniel Hood]

You're welcome,

1) Yes, I actually developed it on 1.2 Beta 3 (I haven't tested any higher but I imagine it works)

2) and 3) these are connected, I fixed both things with his testing and repackaged it so the newest version does have it fixed. The only edit you might have to do is the template hook one but that's only if you don't like the positioning of it by default.

 

[kankan]

@Daniel Hood you're welcome, i feel normal to give feedback on a free plugin i use.
I changed the hook and it displays now ok.
Another issue : in the pined topic list in your plugin panel, there are some pined thread missing. How does your plugin browse pined thread ? (I have a pined poll thread which does not appear for ex)

 

[Daniel Hood]

Those are probably the threads that were erroring before, can you find anything that all threads missing have in common

 

[xfrocks]

Hi @Daniel Hood, you listened to load class event for XenForo_DataWriter_Discussion_Thread but implemented PHCannouncements_DataWriter_Thread the wrong way...

class PHCannouncements_DataWriter_Thread extends XenForo_DataWriter_Discussion_Thread

Should be

class PHCannouncements_DataWriter_Thread extends XFCP_PHCannouncements_DataWriter_Thread

For more information, please read here: http://xenforo.com/community/threads/creating-an-addon.5416/

 

[Daniel Hood]

Hmm, I will look into that. Thanks.

 

[Jeremy]

Hmm, I will look into that. Thanks.

This exists in all of your add-ons. Any where where you are extending a XenForo class, if you use listeners, they should be extending XFCP_CLASSNAME, and XenForo will handle resolving them and extending the proper classes. This allows multiple add-ons to extend the same class.

You already have the listeners set up, you should just have to change what they extend.

Daniel, if you would like an explaination, I have just added a resource that explains the Proxy System:
http://xenforo.com/community/resources/understanding-the-xenforo-class-proxy-system.2080/

 

[Daniel Hood]

well thanks for pointing it out sooner