1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed vB->XF Import: When migrating from vB 3.8 to XF, buddies aren't not properly processing vB buddylist

Discussion in 'Resolved Bug Reports' started by AlexT, Mar 28, 2013.

  1. AlexT

    AlexT Well-Known Member

    Version: XF 1.1.4

    When migrating from vB 3.8 to XF, buddies aren't properly imported. In library/XenForo/Importer/vBulletin.php, around lines 1243:

    PHP:
    if ($user['buddylist'])
    {
        
    $buddyIds array_slice(explode(' '$user['buddylist']), 01000);
        
    $buddyIds $this->_importModel->getImportContentMap('user'$buddyIds);
        
    $this->_importModel->importFollowing($importedUserId$buddyIds);
    }
    Here the getImportContentMap() method is called to map userids contained in $buddyIds from old to new. The problem: the content map, or xf_import_log respectively, doesn't contain all userids yet; it is being filled as new users are processed.

    For example, someone with user ID 1 will always have his $buddyIds array erased, and as a consequence will follow nobody, because his user account is the first to be migrated, and xf_import_log doesn't contain any userid maps yet. In other words, whenever there is someone in the buddylist who has not been migrated yet (usually someone with a higher userid), that userid will be removed from the current $buddyIds array.

    Related question: I have the "Retain imported content IDs" option selected. Why is the importer still going through the various ContentMaps, which add additional queries for each migrated content item? In cases where 1 will always => 1 (like with user ids), wouldn't it be beneficial if the importer skipped ContentMaps here?
     
    Adam Howard, Alien, Walter and 2 others like this.
  2. Marcus

    Marcus Well-Known Member

    the imported buddy list vb4 > xf 1.1.2 was also mostly incomplete for most of my members
     
  3. Hornstar

    Hornstar Well-Known Member

    Nice find. Will be good to have this fixed when I do my vb3.8 bigboard import.
     
  4. Kier

    Kier XenForo Developer Staff Member

    I'll see what I can do with this.
     
    AlexT, Andrej and Hornstar like this.
  5. Kier

    Kier XenForo Developer Staff Member

    Fixed, and it also handles the ignore list as well now :)

    Screen Shot 2013-06-19 at 13.05.37.png
     
    Eagle, shenmuee, Moshe1010 and 4 others like this.
  6. rellek

    rellek Well-Known Member

    Does it import edit history from vB 3.8 too?
     
    xf_phantom likes this.
  7. Kier

    Kier XenForo Developer Staff Member

    That's on our list of things to do, but I can't tell you precisely when just yet.
     
    0ptima, rellek and xf_phantom like this.
  8. rellek

    rellek Well-Known Member

    Great, thanks for your reply. (y)
     

Share This Page