Fixed vB Importer: Unnecessary htmlentities for User Fields

rellek

Well-known member
Hi,

I was playing around with some import from vB 3.8 to XF and I found that the importer does htmlentities to the user fields. So it comes that we get & when before there was &.

Look at the attachments and you'll see what I mean. There is Occupation/Beruf.

Thanks for your time.
 

Attachments

  • Bildschirmfoto 2013-07-01 um 21.23.46.png
    Bildschirmfoto 2013-07-01 um 21.23.46.png
    40.1 KB · Views: 37
  • Bildschirmfoto 2013-07-01 um 21.25.38.png
    Bildschirmfoto 2013-07-01 um 21.25.38.png
    29.6 KB · Views: 37

Kier

XenForo developer
Staff member
I'm sure there's a reason for that... I'm trying to remember if there was a vBulletin option to htmlspecialchars user fields... looking into it now.
 

Mike

XenForo developer
Staff member
Can you provide a dump of your vB database? (Don't need threads and posts, just users.)
 

Mike

XenForo developer
Staff member
The simplest thing would be the whole database as it pulls from different tables, but I could probably manage with just the custom field and user field related data.
 

Mike

XenForo developer
Staff member
Right, me being sort of stupid here - there was a legitimate bug in the custom field import but it was separate from this. We have a few standard fields that get imported from custom fields.

In this case, changing this line of library/XenForo/Importer/vBulletin.php:
Code:
$import['occupation'] = $this->_convertToUtf8($user['field4']);
to:
Code:
$import['occupation'] = $this->_convertToUtf8($user['field4'], true);
Sorts it. This applies to the 3 other instances directly above it as well.

Thanks for the test data. :)
 
Top