Fixed vB Importer: Unnecessary htmlentities for User Fields

[rellek]

Hi,

I was playing around with some import from vB 3.8 to XF and I found that the importer does htmlentities to the user fields. So it comes that we get & when before there was &.

Look at the attachments and you'll see what I mean. There is Occupation/Beruf.

Thanks for your time.

 

[Kier]

I'm sure there's a reason for that... I'm trying to remember if there was a vBulletin option to htmlspecialchars user fields... looking into it now.

 

[Mike]

It actually appears to just not do the extra decode that's necessary, so fixed now.

 

[rellek]

Well, it still converted & to & in XF 1.2 RC 1.

 

[Mike]

Can you provide a dump of your vB database? (Don't need threads and posts, just users.)

 

[rellek]

Do you mean everything but post, thread, pmtext, pm or just userfields and user?

 

[Mike]

The simplest thing would be the whole database as it pulls from different tables, but I could probably manage with just the custom field and user field related data.

 

[rellek]

PC'd you.

 

[Mike]

Right, me being sort of stupid here - there was a legitimate bug in the custom field import but it was separate from this. We have a few standard fields that get imported from custom fields.

In this case, changing this line of library/XenForo/Importer/vBulletin.php:

$import['occupation'] = $this->_convertToUtf8($user['field4']);

to:

$import['occupation'] = $this->_convertToUtf8($user['field4'], true);

Sorts it. This applies to the 3 other instances directly above it as well.

Thanks for the test data.

 

[rellek]

Sounds good You're welcome. I hope you still have the data as there is another bug...