Not a bug Upload via image icon redundant full image button

[Mr Lucky]

Affected version

RC2

If you upload an image the old fashioned way via the attach button, then before the image is inserted into post you click on either full image or thumbnail and as you might expect, that is what gets inserted into the body of the post.

HOWEVER

with the lovely new fangled method of uploading via the image icon at the top of the text editor, the image gets inserted into the post immediately.

So if you want full page, you just leave it as it is - no point having the full image button because that just duplicates the image.a thumbnail and click on thumbnail then you get post

If you want a thumbnail, you need to fist delete the fun image that got inserted, then click on the thumbnail button.

I think the two things should be consistent, the old way seems more logical that you make the choice before insertion

 

[Mike]

I don't think this is a bug and I can't say I really think it makes sense to change it. The context of these two things is different. One is in a menu explicitly labelled "insert image" and thus it's very directly tied to inserting what you're after into the content. "Attach files" is more generic (more than images) and doesn't necessarily imply anything about inserting into the content.

In this sense, it's also really the same as just dragging an image into the editor.

In terms of the buttons, I think you're proposing hiding/disabling them if they've been used, though I don't really see any real advantage to that. Just disadvantages if images are being used as decorative elements and thus repeated (which I have actually seen, including in an issue I was debugging the other day).

 

[Mr Lucky]

So what do you do (via the image icon) if you want just a thumbnail? Are you supposed to upload, then delete the inserted full image, then click on thumbnail?

Seems very unintuitive to me.

 

[Chris D]

When you click the "Insert image" button you're explicitly saying that you want to insert the image, full size, into the post. If that's not what you want to do, then you would use the "Attach files" button instead.

 

[Mr Lucky]

I agree, but in which case, that is what I'm saying: those buttons (Full and Thumb) are therefore redundant and needn't be there. It actually confuses people.

 

[Martok]

I agree, but in which case, that is what I'm saying: those buttons (Full and Thumb) are therefore redundant and needn't be there. It actually confuses people.

I'm not sure it's confusing. When you upload an image via the old method (on either XF 1.x or 2.0) and then insert a thumbnail or full image, those buttons still remain there, they don't disappear (and quite rightly too, there may be reasons for someone to insert the image more than once).

All that the new method does is remove a step and save on clicking the insert full image button.

 

[Mr Lucky]

All that the new method does is remove a step and save on clicking the insert full image button.

I agree, but the problem is people are inserting the image and then clicking on a button that doesn't need to be there. Result: the image is there twice.

 

[Martok]

I agree, but the problem is people are inserting the image and then clicking on a button that doesn't need to be there. Result: the image is there twice.

Really? How many people are doing this?

Currently you upload image > click full image button > see image on screen (and rather large too if it's a big image) > don't click full image button again. Now you insert image (via upload) > see image on screen > don't click full image button.

I really can't see how this can be confusing. You either see the image inserted into your post or you don't. If you don't, you click on the insert full image button and then you see it (and you don't click it anymore). If you do, you don't click the button (again).

I can only assume that these (presumably) very small number of people either have visual difficulties or are just doing it out of habit because they are used to the old way and aren't thinking and looking at their screen. They'll soon learn.

 

[RobinHood]

Jumping in here as I think the whole ‘attach files’ button could do with rethinking in general.

The editor tool bar is busy and full, and most users won’t take the time to figure out what each button means.

They know they want to attach or insert some kind or media or file to their post, so they use the obvious big CTA below the editor.

The problem is that it’s not a ‘smart’ way of inserting or attaching media. It doesn’t differentiate between images, video or file attachments, but it should.

Looks at facebook’s method for attaching or inserting content to a post.

The entire tap target in the red area below is effectively one button, ‘attach files’ or ‘insert media or some other type of non Text content



It results in a menu asking the user what kind of content they want to insert or add to their post:



Personally I think this menu is a bit busy and mad, but it’s partly that way because fbook has so many extra post content features.

I do believe though that some inspiration could be drawn from this and some kind of direct full screen or modal guidance could be offered to the user in terms of inserting and embedding their media or attachment into the post after uploading to get the desired effect.

Ps: I’m not sure why, but the editor was spazzing out big time for me trying to write this final bit of Text on an iPhone X running 11.1.2

There’s definitely some kind of bug there

It nearly made me give up. I think it keeps trying to re focus on the first full size inserted image

 

[Mr Lucky]

I really can't see how this can be confusing. You either see the image inserted into your post or you don't. If you don't, you click on the insert full image button and then you see it (and you don't click it anymore). If you do, you don't click the button (again).

Yes, they can see the image, but they also see two buttons offering full or thumbnail, which we now know they aren't supposed to click on. So why have them?

This caught me out for a while and I'm (presumably) a bit more computer literate than many of my users.

I totally agree, you insert the image . There it is in the post. Why have these buttons shouting at you to click them as if you now need to make a choice????

 

[Martok]

I totally agree, you insert the image . There it is in the post. Why have these buttons shouting at you to click them as if you now need to make a choice????

Because there may be occasions that you want to insert the same image a second or more times.

Those buttons have always been there even after an image has been inserted, there's no no change in that fact.

 

[Mr Lucky]

Really? How many people are doing this?

Quite a few

Because there may be occasions that you want to insert the same image a second or more times.

I can’t think what those occasions are. And if you really want to that then copy and paste would be the obvious way to do that.

 

[Martok]

And if you really want to that then copy and paste would be the obvious way to do that.

That's possible on a PC but not on a mobile device, there's no copy to clipboard option for photos stored on a phone or tablet as far as I can see (at least on Android).

I'm sure users who have had problems with this will get used to it seeing as the devs have decided currently to leave it as it is. However you could post a suggestion for them to consider if you think it's an issue that should be addressed.