1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Partial Fix Too many quotes

Discussion in 'Resolved Bug Reports' started by rellek, Aug 29, 2013.

  1. rellek

    rellek Well-Known Member

    Hi,

    an error was logged at my forum:

    ErrorException: Fatal Error: Maximum function nesting level of '100' reached, aborting! - library/XenForo/BbCode/Formatter/Base.php:479
    Erstellt von: Unbekanntes Benutzerkonto, Dienstag um 03:31
    Stapelverfolgung
    #0 [internal function]: XenForo_Application::handleFatalError()
    #1 {main}
    Benötigter Status
    array (size=3)
    'url' => string 'http://board.rellek.org/threads/wer-postet-als-naechstes.1024/page-61' (length=69)
    '_GET' =>
    array (size=0)
    empty
    '_POST' =>
    array (size=0)
    empty

    I'm not exactly sure but I think there are too many quotes. I think it'd be better if the parser would just ignore this whole bunch of nestes BBCodes instead of throwing a blank page...
     
  2. Amaury

    Amaury Well-Known Member

    This sounds more like a suggestion.
     
  3. rellek

    rellek Well-Known Member

    I think a blank page on the user's view is more like a bug, since there's no obvious possibility to fix that either. It doesn't even state which postid contains the many quotes.
     
    Adam Howard likes this.
  4. Chris D

    Chris D XenForo Developer Staff Member

    Not really, Amaury.

    Anything in the software that can cause a server error should be treated as a bug as there's nearly always graceful ways of preventing it getting to an error state.
     
    Adam Howard and rellek like this.
  5. Amaury

    Amaury Well-Known Member

    Fair enough.

    I only said that because of this:
    I think indicates a suggestion to me.
     
  6. rellek

    rellek Well-Known Member

    This was kind of a suggestion how "I" would fix that. But this is just my opinion, maybe Mike or Kier have a better idea. :)
     
    Adam Howard likes this.
  7. rellek

    rellek Well-Known Member

    In case it helps... This is the post that makes problems:

    Code:
    [quote][i]Original von rellek[/i]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    [quote][size=1][i]Original von [b]rellek[/b][/i][/size]
    ts_garp[/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote][/quote]
     
  8. Brogan

    Brogan XenForo Moderator Staff Member

    I was going to ask whether you had edited the code to nest quotes, or do members manually nest them?
     
  9. rellek

    rellek Well-Known Member

    Well, it was posted a long time ago, it was in 2005 when we used Burning Board 2.3. I guess the author wanted to create this effect:
    http://xenforo.com/community/threads/just-a-test.58672/

    This is kinda weird, the problem does not happen here. In my forum, I am unable to re-post this message. It just happens nothing - however an error is logged.
     
  10. Luke F

    Luke F Well-Known Member

    This also occurs more commonly if a large number of spoiler tags are nested (via custom bbcode addon)

    Should be considered a core issue as you can basically DoS an entire thread page using this - the only way to access it again is to edit the post in the database
     
    Last edited: Aug 30, 2013
    digitalpoint, Alien and Adam Howard like this.
  11. Mike

    Mike XenForo Developer Staff Member

    It's worth pointing out that this fatal error is trigged by xdebug and is not a limit in PHP itself. There are recursion limits, though they're likely to be significantly deeper than 100 PHP calls - just for reference, Python's default limit is 1000. You should increase this limit in xdebug.

    That said, I am looking at a depth limit. I "only" see a depth of 20 tags there.
     
    Adam Howard and rellek like this.
  12. rellek

    rellek Well-Known Member

    Thanks, disabling xdebug (whyever I installed it in the first place) fixed that :)
     
    Adam Howard likes this.
  13. xf_phantom

    xf_phantom Well-Known Member

    You should disable xdebug on your live system;)


    Edit: Sorry, hadn't seen the last reply^^
     
    rellek likes this.
  14. Chris D

    Chris D XenForo Developer Staff Member

    Certainly an interesting thread you have there.

    ts_garp

    rellek

    rellek

    rellek

    ts_garp

    o_O
     
  15. rellek

    rellek Well-Known Member

    This is a forum game about who is gonna post after you. This was what we played back then, lol.
     
    Chris D likes this.

Share This Page