1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

As Designed Tagging AutoComplete stops after space is inserted

Discussion in 'Resolved Bug Reports' started by Chris D, Jun 3, 2013.

  1. Chris D

    Chris D XenForo Developer Staff Member

    If I was to start tagging @Rigel Kentaurus as soon as I press space after Rigel the AutoComplete box disappears.
    CyberAP likes this.
  2. Rigel Kentaurus

    Rigel Kentaurus Well-Known Member

    Same if I do @Chris Deeming :)
    I am not sure if that is solvable. Does BD Tag Me do the autocomplete ok in that scenario?

    Update: Tested BD Tag Me, it does not work when pressing space either
  3. Chris D

    Chris D XenForo Developer Staff Member

    Yeah TagMe works fine with spaces in usernames.

    I would expect little teething things such as this though. I know it's taken @xfrocks a long time to get the auto complete stuff just right. Every now and then there's a little tweak that improves the detection of usernames.
  4. Mike

    Mike XenForo Developer Staff Member

    This is currently intentional and it's a balance of being "right" versus making many unnecessary round trips to the server.
    trichome, ibnesayeed, Hoffi and 2 others like this.
  5. xfrocks

    xfrocks Well-Known Member

    I think it's a good idea to stop giving suggestions when user hit space, those usernames are uncommon anyway. For the [bd] Tag Me add-on, it does not support spaces in suggestion by default, administrator has to go into the option page to make it work. Talking about trade offs :D

    PS: @Mike liked my post. Ooh hoo!
    Mike likes this.
  6. DJ XtAzY

    DJ XtAzY Active Member

    If it's possible to make it as an option that would be great. FB handles this quite nicely.
  7. Jeremy

    Jeremy XenForo Moderator Staff Member

    Facebook also explicitly has a space in their names. They also have plenty more processing power.
  8. DJ XtAzY

    DJ XtAzY Active Member

    True, but this is why having an option would be nice and admins should understand that having it enabled will have some tradeoffs.
  9. Shelley

    Shelley Well-Known Member

    Just noticed this when I tried to Tag @Azhria Lilu
    Lee likes this.
  10. Lee

    Lee Well-Known Member

    I agree. A setting to enable this would be nice.

  11. Brogan

    Brogan XenForo Moderator Staff Member

  12. ibnesayeed

    ibnesayeed Well-Known Member

    For some languages many user names without spaces may look ugly. I have this feeling that you have minimum character count setting to fire suggestion popup. Enabling spaces as a configurable option will be nice to have as well. :)
  13. Jeremy

    Jeremy XenForo Moderator Staff Member

    It appears as if this has been "FIXED" since I can now type @King Kov and it'll show an auto-complete of my name. Way to go, Mike & Kier! (y)
  14. Mike

    Mike XenForo Developer Staff Member

    It allows spaces in the first 8 characters I think. Beyond that, it just assumes you're done. Seems like a reasonable compromise.
    ibnesayeed and Jeremy like this.
  15. Teapot

    Teapot Well-Known Member

    That sounds absolutely ideal. Thanks!
  16. ibnesayeed

    ibnesayeed Well-Known Member

    Is this a configurable number?
  17. Brogan

    Brogan XenForo Moderator Staff Member

    Only in code so it will require a file edit.
    ibnesayeed likes this.
  18. James

    James Well-Known Member

    @Mike if it finds the user, perhaps the suggestion should persist?

    Example: If I go to tag Chris Deeming, It'll provide suggestions up to "Chris De", after which point it will remove the suggestion box completely.

    Perhaps the suggestion box should remain for the rest of the name? I'm not sure if there would be any overhead seeing as the name was already matched.
  19. TheBigK

    TheBigK Well-Known Member

    Is there any way I can change the character limit? On our boards, several users have their usernames as 'Firstname Lastname'. Many first names are more than 8 chars long and I'd like them to appear in the tagging suggestions.

    I've read that this may affect the server performance. I wish to know more about it. I'm ready to load the server in favor of the feature. What could be the adverse effects of this on our server?
  20. Brogan

    Brogan XenForo Moderator Staff Member

    I believe it has now been increased to 10.

    You will need to edit the code to increase it further.

Share This Page