Right now the [bd] Attachment Store addon has to redundantly store various config options in every row of the xf_attachment_data table, because XF's Attachment model class doesn't allow for extra JOIN clauses. If it did, a separate table could be created to store those backend options without much performance impact (no additional queries).
I'd like to propose adding a static var $dataJoins in XenForo/Model/Attachment.php, similar to $dataColumns. It would contain one or more JOIN clauses that would be used in places like getAttachmentsByContentIds. In fact I've already implemented this, but I'd like to avoid having to maintain a custom version of XenForo if possible. I can post the diff for my changes, if that would be helpful.
I'd like to propose adding a static var $dataJoins in XenForo/Model/Attachment.php, similar to $dataColumns. It would contain one or more JOIN clauses that would be used in places like getAttachmentsByContentIds. In fact I've already implemented this, but I'd like to avoid having to maintain a custom version of XenForo if possible. I can post the diff for my changes, if that would be helpful.
Upvote
0