1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Select for thread moderation problem

Discussion in 'Resolved Bug Reports' started by AndyB, Jul 21, 2013.

  1. AndyB

    AndyB Well-Known Member

    As of v1.2b5 when I go to a thread and try to select it for moderation, it will not select.

    Marcus likes this.
  2. Brogan

    Brogan XenForo Moderator Staff Member

    Which browser and OS?

    Works fine for me in Chrome/Win & Android.
  3. AndyB

    AndyB Well-Known Member

    I'm using OSX 10.8.4 and Firefox 22.
  4. Shelley

    Shelley Well-Known Member

    Works fine for me in Firefox 22 win7

  5. AndyB

    AndyB Well-Known Member

    The bug has happened to me a number of times, but I'm not able to reproduce it. Appears to be an intermittent bug.

    Hopefully others will chime in indicating it has happened to them also.
  6. AndyB

    AndyB Well-Known Member

    Steps to reproduce:

    1) Browse to a forum (this will be your first tab)
    2) Open new tab (this will be your second tab)
    3) Browse to a forum and click a thread title
    4) Click Thread Tools
    5) Click Select for Thread Moderation
    6) Click your first tab
    7) Select a thread for moderation

    Notice how only one thread is being shown as "Selected Threads: 1".
  7. Brogan

    Brogan XenForo Moderator Staff Member

    That behaviour is typical when performing moderation with multiple tabs.

    You need to save the state of the first tab and refresh the second tab before attempting further moderation actions.
  8. Mike

    Mike XenForo Developer Staff Member

    I'm not totally sure about the feasibility of fixing that. It depends if cookies in JS are updated immediately, even when another tab changes them.
  9. AndyB

    AndyB Well-Known Member

    Mike, have you considered using the database to store selected threads for moderation?
  10. Jeremy

    Jeremy Well-Known Member

    Storing it in the database would require an AJAX request and query per select / unselect of a thread for moderation. The current method is fast and doesn't require a delayed response.

    Plus, changing the method at this point could potentially introduce more problems, so it would have to be a suggestion.
    Amaury likes this.
  11. AndyB

    AndyB Well-Known Member

    Good points, King Kovifor.

    Another option would be to allow pasting a URL of the thread to be merged. So instead of clicking the Thread Tools and selecting the thread, the admin would copy the URL, then select another thread from a forum-view and then invoke the Merge Thread option where an input box would allow pasting the URL of the other thread to be merged.
  12. Mike

    Mike XenForo Developer Staff Member

    This should be fixed for the next 1.2 release now. It generally does a better job of merging the changes from ultiple tabs without reloading.
    Pereira and AndyB like this.
  13. Brogan

    Brogan XenForo Moderator Staff Member

    I wish I had reported this years ago, it has been a pain sometimes :D
    Pereira likes this.
  14. AndyB

    AndyB Well-Known Member

    Thank you, Mike.

Share This Page