Search Improvements 2.17.0

[Xon]

If you are using any of these add-ons:

1. Standard Lib
2. Search Improvements
3. Conversation Improvements
4. Report Improvements
5. Report Center Essentials
6. ElasticSearch Essentials
7. Then do a full rebuild of the search index, using the "delete" option.

Please make sure you update them to the latest version in that order. It will save you a pile of pain and compatibility issues.

 

[SeToY]

I just installed Search Improvements (as it is now required for Conversation Improvements) and now have a new entry "Enhanced search - Indexes" in my admincp in the "Setup" menu, which leads to:

Oops! We ran into some problems.​

The requested page could not be found.

 

[Xon]

That is a hook point for my Tag/username auto-complete search addons. But it shouldn't be doing that

That it even shows up means most of the add-on is installed, but the link failing means the add-on is in a zombie state or a 3rd party add-on is causing issues.

 

[SeToY]

I had standard lib installed in the latest version already (1.18.2), installed search improvements and then updated conversation improvements from v2.3.0 to v2.4.0 (files were already uploaded, just didn't click the "upgrade" button before installing search improvements).

Then I reset the search index with the "delete" option checked.

Which additional information do you need?

 

[Xon]

I had standard lib installed in the latest version already (1.18.2), installed search improvements and then updated conversation improvements from v2.3.0 to v2.4.0 (files were already uploaded, just didn't click the "upgrade" button before installing search improvements).

Which additional information do you need?

Can you check the add-on list and see if there is any errors against my add-ons?

But this is looking like a conflict with another add-on, which will require more understanding of your site's add-ons or access to check the code for known bad patterns.

Otherwise can you open a ticket on my site? As this is likely going to require some troubleshooting to isolate what is happening.

 

[SeToY]

Otherwise can you open a ticket on my site? As this is likely going to require some troubleshooting to isolate what is happening.

Done 2577

 

[Xon]

This appears to be a bug when XFES isn't enabled/installed. Please let me know if you encounter an additional issues without XFES installed and I'll work on fixing those.

 

[Xon]

Xon updated Search Improvements with a new update entry:

2.9.2 - Bugfix update

• Fix additional XFES index page would show even when XFES was not installed/active

Read the rest of this update entry...

 

[NealC]

I think this update just made my Admin left nav bar make the Enhanced Search item go missing. I have enhanced search and now don't have the link above your ES - Indexes item.

 

[MentaL]

I've removed the plugin during some tests and got the following;

• ErrorException: Fatal Error: Trait "SV\SearchImprovements\Search\DiscussionTrait" not found
• src/addons/SV/ReportImprovements/Search/Data/Report.php:21

suggestions? it seems as if Xen is still trying to call the plugin,.

 

[Nirjonadda]

I think this update just made my Admin left nav bar make the Enhanced Search item go missing. I have enhanced search and now don't have the link above your ES - Indexes item.

Yes I have also same issues.

 

[MentaL]

being bombarded with error messages.

 

[NealC]

being bombarded with error messages.

rebuild search index with delete first

 

[SeToY]

being bombarded with error messages.

Care to elaborate on those error messages? Perhaps even post them? Or should Xon just try to guess which ones you're being bombarded with?

 

[MentaL]

rebuild search index with delete first

ErrorException: Fatal Error: Trait "SV\SearchImprovements\Search\DiscussionTrait" not found src/addons/SV/ReportImprovements/Search/Data/Report.php:21


and yet the file exists and the plugin is activated. if I uninstall it to bypass, the plugin still acts as if its "enabled", rather perplexing.

I've recently bought elasticsearch (several hours ago) and i would like to use it. In this instance as I write this, I've "uninstalled" the plugin via the admincp: I visit the elasticsearch panel and get hit with a 500. If I go to root domain and go /search/ i hit a 500.

• ErrorException: Fatal Error: Trait "SV\SearchImprovements\Search\DiscussionTrait" not found
• src/addons/SV/ReportImprovements/Search/Data/Report.php:21

Uploading the plugin again allows me to access the admin/search but I cannot rebuild as it then outputs the "not found" error again despite it physically being on the server.



I'm wondering if there are some residuals left over in the DB causing the conflict or something causing the intermittence. Maybe its a conflict with Report Improvements. I will remove this and update you all.

Update; began a rebuild # php cmd.php xf-rebuild:search --truncate




Update. All working now and able to rebuild since the removal of the report adding. Could be singular to me though.

 

[Xon]

I think this update just made my Admin left nav bar make the Enhanced Search item go missing. I have enhanced search and now don't have the link above your ES - Indexes item.

Yes I have also same issues.

This is expected, as the only way for the admin nav item to only show when XFES is enabled it to be a child of it, which makes it non-clickable. The same entry is available by clicking 'view' on the default index so it is just an annoyance

I've removed the plugin during some tests and got the following;

• ErrorException: Fatal Error: Trait "SV\SearchImprovements\Search\DiscussionTrait" not found
• src/addons/SV/ReportImprovements/Search/Data/Report.php:21

suggestions? it seems as if Xen is still trying to call the plugin,.

Report Improvement requires Search Improvements, so this is expected. XenForo's requirement system isn't robust enough to prevent an admin from disabling an add-on which is required by another add-on. Or at least disabling anything which has a dependency on the add-on you just disabled.

 

[MentaL]

That makes sense. Ive only recently migrated from VB after 20 years. Still learning.

 

[Mark7783]

Since updating my error log is full of this. I've tried uninstalling SearchImprovements, ReportImprovements and ElasticSearchEssentials then installing them again but it keeps coming back. I also did a full search rebuild

ErrorException: Template error: [E_WARNING] Cannot declare class SV\SearchImprovements\XF\Entity\XFCP_ThreadCollab, because the name is already in use. src/XF/Extension.php:171

Stack trace​

#0 [internal function]: XF\Template\Templater->handleTemplateError(2, '[E_WARNING] Can...', '/home/admin/dom...', 171)
#1 src/XF/Extension.php(171): class_alias('SV\\ElasticSearc...', 'SV\\SearchImprov...')
#2 src/XF/Mvc/Entity/Manager.php(55): XF\Extension->extendClass('XF\\Entity\\Threa...')
#3 src/XF/Mvc/Entity/Manager.php(125): XF\Mvc\Entity\Manager->getEntityClassName('XF:Thread')
#4 src/XF/App.php(2850): XF\Mvc\Entity\Manager->find('XF:Thread', 190, Array)
#5 src/addons/SV/SearchImprovements/XF/Entity/Search.php(166): XF\App->find('XF:Thread', 190)
#6 src/addons/SV/ReportImprovements/XF/Entity/Search.php(154): SV\SearchImprovements\XF\Entity\Search->getSpecializedSearchConstraintPhrase('thread', '190')
#7 src/addons/SV/ElasticSearchEssentials/XF/Entity/Search.php(30): SV\ReportImprovements\XF\Entity\Search->getSpecializedSearchConstraintPhrase('thread', '190')
#8 src/addons/SV/SearchImprovements/XF/Entity/Search.php(236): SV\ElasticSearchEssentials\XF\Entity\Search->getSpecializedSearchConstraintPhrase('thread', '190')
#9 src/addons/SV/SearchImprovements/XF/Entity/Search.php(311): SV\SearchImprovements\XF\Entity\Search->getSearchConstraintPhrase('thread', '190')
#10 src/addons/SV/SearchImprovements/XF/Entity/Search.php(465): SV\SearchImprovements\XF\Entity\Search->extractUnstructuredSearchConstraint(Array, Array, '')
#11 src/XF/Mvc/Entity/Entity.php(167): SV\SearchImprovements\XF\Entity\Search->getSvUnstructuredQuery()
#12 src/XF/Mvc/Entity/Entity.php(125): XF\Mvc\Entity\Entity->get('sv_unstructured...')
#13 internal_data/code_cache/templates/l1/s3/public/svSearchImprov_search_results.php(10): XF\Mvc\Entity\Entity->offsetGet('sv_unstructured...')
#14 src/XF/Template/Templater.php(1652): XF\Template\Templater->{closure}(Object(SV\WarningImprovements\XF\Template\Templater), Array, NULL)
#15 src/XF/Template/Templater.php(1681): XF\Template\Templater->renderTemplate('svSearchImprov_...', Array)
#16 internal_data/code_cache/templates/l1/s3/public/search_results.php(27): XF\Template\Templater->includeTemplate('public:svSearch...', Array)
#17 src/XF/Template/Templater.php(1652): XF\Template\Templater->{closure}(Object(SV\WarningImprovements\XF\Template\Templater), Array, NULL)
#18 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('search_results', Array)
#19 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#20 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Html->renderView('XF:Search\\Resul...', 'public:search_r...', Array)
#21 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#22 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#23 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#24 src/XF/App.php(2483): XF\Mvc\Dispatcher->run()
#25 src/XF.php(524): XF\App->run()
#26 index.php(20): XF::runApp('XF\\Pub\\App')
#27 {main}

 

[Xon]

Do you have your site in debug or developer mode?

Remove the src/addons/SV/SearchImprovements/_output folder, and upload the add-on files, and then re-install Search Improvements.

 

[woody]

Reindexing search is always a good time.... one hour in, still not done with Conversation Messages (3m indexed thus far)...