Favicons started not working for me suddenly. Like some do work, some doesn't. Anyone else having the same issue?
I can confirm this.
I think there is another add-on for the same purpose around here, but I'm not finding.
If someone knows, please share with us.
Everything is still working fine on my side, even with the adjustment to remove favicons for my own site.Favicons started not working for me suddenly. Like some do work, some doesn't. Anyone else having the same issue?
Even my internal links, so stuff from my own board has no favicons. I will try to reinstall the addon, it seems a problem specific to me, thanks.Everything is still working fine on my side, even with the adjustment to remove favicons for my own site.
Only some will not show, and as a world, if they don't have a favicon or their headers pass something other than an OK status (even though viewable).
Maybe it's a conflict with a newer version of XF? I'm still on 2.1.5a.Even my internal links, so stuff from my own board has no favicons. I will try to reinstall the addon, it seems a problem specific to me, thanks.
I'm not sure what you mean, but if you want to disable it in specific forums, try adding to your css something like
Replace 15 with the relevant forum id.CSS:body[data-container-key="node-15"] .link.has-favicon { background: none !important; padding: 0px !important; }
<!--XF:JS-->
<xf:if is="'public' === $app">
<xf:macro template="rellect_favicon" name="script" />
</xf:if>
<!--XF:JS-->
<xf:if is="!in_array($__globals.forum.node_id, [1,2,3,4,5])">
<xf:if is="'public' === $app">
<xf:macro template="rellect_favicon" name="script" />
</xf:if>
</xf:if>
//https://www.google.com/s2/favicons?domain=
var matches = link.getAttribute('href').match(/^https?\:\/\/([^\/?#]+)(?:[\/?#]|$)/i);
var domain = matches && matches[1]; // domain will be null if no match is found
link.style.backgroundImage = "url('https://favicons.githubusercontent.com/" + domain + "')"
For anyone using my mod published above as a ZIP file. It looks like http://favicons.githubusercontent.com went offline lately resulting in missing favicons. Since those guys were still not on Google S2 and since my mod does extract the hostname already anyway I just started using the actual favicons URLs in that map. Like:Actually GitHub favicon service is far from perfect either.
I had implemented some clever AJAX version that would use both services to get the best favicon but that won't work on production because of cross site security issues. Instead I did a not so clever implementation with hardcoded URL target per hostname. It can also invert favicon color if needed for those of us running dark themed forums.
const KHostNames = {
"stackoverflow.com": { url:KRequestFaviconGoogle+"stackoverflow.com", invert:0 },
"theregister.co.uk": { url:KRequestFaviconGoogle+"theregister.co.uk", invert:1 },
"github.com": { url:"https://github.com/favicon.ico", invert:1 },
"android.googlesource.com": { url:KRequestFaviconGoogle+"googlesource.com", invert:0 },
"developer.android.com": { url:"https://developer.android.com/favicon.ico", invert:0 },
"download.lenovo.com": { url:KRequestFaviconGoogle+"lenovo.com", invert:0 }
};
[Nulumia] XFOptimize
addon. Just a fyi!So, getting generic icon on 2.3B3. Not sure if the developer is still active on the community. Would really miss this addon on 2.3 if this remains unmaintained.
We use essential cookies to make this site work, and optional cookies to enhance your experience.