Fixed Possible Bug in XenForo_Option_NodeChooser

[ragtek]

Check pls the method getNodeOptions

i'm trying to create a nodeselected checkbox
if i use this code

        $forumOptions = XenForo_Option_NodeChooser::getNodeOptions(
            $value['node_id'],
            sprintf('(%s)', new XenForo_Phrase('unspecified')),
            'Forum'
        );

i'm getting this error.

[SIZE=3][B]Template Errors: ragtek_fw_option_nodemultiselect[/B][/SIZE]

[LIST=1]
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121
[*][I]Invalid argument supplied for foreach()[/I] in C:\xampp\htdocs\xenforo\library\XenForo\Template\Helper\Admin.php, line 1121

[/LIST]
problem is, that this check can't be run,

    if (!empty($option['node_type_id']) && $option['node_type_id'] != $filter)

if includeroot is set to true in nodemodel getNodeOptionsArray

as you see here,

    public function getNodeOptionsArray(array $nodes, $selectedNodeId = 0, $includeRoot = false)
    {
        $options = array();

        if ($includeRoot !== false)
        {
            $root = $this->getRootNode();

            $options[0] = array(
                'value' => 0,
                'label' => (is_string($includeRoot) === true ? $includeRoot : $root['title']),
                'selected' => (strval($selectedNodeId) === '0'),
                'depth' => 0,
            );
        }

the first element doesn't have a node_type_id and that's why the check is making troubles

 

[ragtek]

ok this wasn't the problem

The problem was this admin template helper:

    protected static function _getDisablerHtml(array $optionInfo, $optionId)
    {
        
        if ( !empty($optionInfo['disabled']))
        {
            $disablerHtml = "\n<ul id=\"{$optionId}_Disabler\">";
            foreach ($optionInfo['disabled'] AS  $disabled)
            {
                $disablerHtml .= "\n<li>$disabled</li>";
            }
            $disablerHtml .= "\n</ul>\n";
        }

        return $disablerHtml;
    }

it checks only, if $optionInfo['disabled'] is set, but not if it's an array (which is requested for the foreach)
This solved the problem:

    protected static function _getDisablerHtml(array $optionInfo, $optionId)
    {
        $disablerHtml = '';
        if ( !empty($optionInfo['disabled']) AND is_array($optionInfo['disabled']))
        {
            $disablerHtml = "\n<ul id=\"{$optionId}_Disabler\">";
            foreach ($optionInfo['disabled'] AS  $disabled)
            {
                $disablerHtml .= "\n<li>$disabled</li>";
            }
            $disablerHtml .= "\n</ul>\n";
        }

        return $disablerHtml;
    }

Don't know if it's a xenforo bug

 

[Kier]

Can't hurt to have the check in place.