Password Tools 2.3.5

[Lukas W.]

katsulynx submitted a new resource:

[KL] Password Tools - Cause safer passwords are better passwords.

[KL] Password Tools
Description

View attachment 114132
Source​

This modification mostly follows the principles of Dan Wheelers password strength estimator zxcvbn. It does not weight password strength by their combination of upper/lower letters, special characters and numbers, but on...

Read more about this resource...

 

[Xon]

What licence does this have? (ie using the XF resource manager licencing field)

 

[rafass]

Thanks for this great addon katsulynx
I'll test in 1.5.0RC2

 

[Lukas W.]

What licence does this have? (ie using the XF resource manager licencing field)

MIT Licence, updated said field. The Licence for Zxcvbn is included in the download.

 

[rafass]

 

[Lukas W.]

Woopsie, forgot to include the screenshots

 

[Xon]

    public static function extend($class, array &$extend) {
        if (!class_exists('XFCP_KL_PasswordTools_DataWriter_User', false)) {
            $extend[] = 'KL_PasswordTools_DataWriter_User';
        }
    }

No point adding the class_exist checks, you can just append to $extend blindly. (You can add a version check in for < XF1.2 so you can always ensure the hint is respected)

 

[Xon]

Your addon looks fairly straight forward and well put together.

A few other bits:

1. Should respect the "$requirePassword". When migrating between authentication providers, the requirePassword is false and permits and empty password to be stored.
2. IMO, the large json should be converted into php arrays, this will then allow opcode caching to handle those files rather than causing ~3mb of IO every time someone sets a password.

 

[Lukas W.]

katsulynx updated [KL] Password Tools with a new update entry:

Various Improvements

• Converted JSON-Files to PHP-Files to allow for OpCode-Caching
• Removed unnecessary code
• Fixed possible incompatibility with external auths
• Included own licence file

Thanks to @Xon for these suggestions.

Read the rest of this update entry...

 

[Xon]

Small template mod tweak, You have the following repeated twice:

<xen:require js="js/KL/PasswordTools/zxcvbn-async.js" />
<xen:require js="js/KL/PasswordTools/PasswordStrengthMeter.js" />
<xen:include template="KL_PasswordStrengthMeter_Setup" />

Any reason those javascript include aren't be pushed into the KL_PasswordStrengthMeter_Setup template to make the template modifications simpler?


The default text strength colour on a dark theme are fairly unreadable:

 

[Lukas W.]

Any reason those javascript include aren't be pushed into the KL_PasswordStrengthMeter_Setup template to make the template modifications simpler?

I've actually tried that, but it didn't work for a reason I wasn't able to identify.

The default text strength colour on a dark theme are fairly unreadable:
View attachment 114157

You can change that in the Style Properties. 'Segments' holds the default color for the bars, 'Phrase' the one for the phrase.

 

[BobbyWibowo]

This is being applied to the ones on registration page and password change, correct?

 

[Lukas W.]

This is being applied to the ones on registration page and password change, correct?

Exactly.

 

[Xon]

I've actually tried that, but it didn't work for a reason I wasn't able to identify.

Weird.

You can change that in the Style Properties. 'Segments' holds the default color for the bars, 'Phrase' the one for the phrase.

Could you set the 'Phrase' default foreground color to something like @textCtrlText rather than an an explicit hardcoded color? This will then work properly across most themes without modification.

 

[rafass]

In 1.5.0RC2 is not working.
I've seen that require FA. in my case I don't have and I don't want to use FA,
would be great make this optional, if possible.

 

[Lukas W.]

I've seen that require FA. in my case I don't have and I don't want to use FA,
would be great make this optional, if possible.

It is optional.

 

[Lukas W.]

Could you set the 'Phrase' default foreground color to something like @textCtrlText rather than an an explicit hardcoded color? This will then work properly across most themes without modification.

Changed to @mutedTextColor for the next version.

In 1.5.0RC2 is not working.

Double-checked that, couldn't find anything not working though. What exactly is not working for you?

 

[BobbyWibowo]

Am I doing something wrong? Getting this error on registration (after filling details then sign up). I'm on XenForo 1.4.10.

 

[rafass]

editing with more info...

 

[BobbyWibowo]

Still waiting for stable 1.5, lol