Fixed Overlay share icons link to the page below, not the overlay URL

[Mr Lucky]

Affected version

2.2.8

I've tested this on the xenForo demo.
If I create a page, add it to the main navigation and make it open in an overlay via the Extra attributes data-xf-click overlay, then when it opens the share icons link to whatrever is the page below, not the overlay page.

So in the screenshot, the share link will be forums instead of the test page.

I understand that an external link may not be able to activate the overlay, but if the share links are there in the overlay, then they should at least open that page normally.

One more little possible buglet is that there is no left padding for the share buttons.

 

[Mr Lucky]

I'm fairly sure there is 99% chance that most people never want to share to an overlay anyway so I think the icons are redundant here

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.9).

Change log:

When opening a page in an overlay that contains share buttons, override the page URL to the URL of the overlay loaded.

There may be a delay before changes are rolled out to the XenForo Community.

 

[Mr Lucky]

Thank you for reporting this issue, it has now been resolved.

The padding issue has not been fixed though. Should I start a new bug report Mr Bug Bot?

 

[Old Nick]

Fixed bugs are not monitored dixit @Jeremy P