1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Odd overlay issue. Member Card > Trophy Points

Discussion in 'Resolved Bug Reports' started by Chris D, Jul 29, 2013.

  1. Chris D

    Chris D XenForo Developer Staff Member

    I am getting this weirdness after a specific set of actions:

    upload_2013-7-29_22-12-9.png

    This is on Chrome 28 on OS X Mountain Lion.

    I took these steps:
    • Clicked my avatar in the quick reply area to bring up my own member card.
    • Clicked the trophy points number to load the trophies overlay.
    • Clicked outside of the overlay (I did not click the Close button).
    • Clicked my avatar again.
    • Clicked the trophy points number again.
     
  2. Brogan

    Brogan XenForo Moderator Staff Member

    Doesn't do it on Chrome/Win 7 or Chrome/Android.
     
  3. Chris D

    Chris D XenForo Developer Staff Member

    Jeremy likes this.
  4. Jeremy

    Jeremy XenForo Moderator Staff Member

    If it makes you feel any better, this happened on a Followers overlay for me once or twice and just like you, I couldn't replicated it again.
     
  5. Andrej

    Andrej Well-Known Member

    Can't reproduce on Google Chrome 28.0.1500.71 on Mac OS X Mountain Lion 10.8.4 after several attempts.
     
  6. Chris D

    Chris D XenForo Developer Staff Member

    Goddamn you overlays!

    * Shakes fist
     
    tafreehm, Bob and Jeremy like this.
  7. Chris D

    Chris D XenForo Developer Staff Member

    This was annoying me. So I thought I'd try it once more, today.

    I'm on Windows today. Still on Chrome:

    upload_2013-7-30_10-5-28.png
     
  8. Chris D

    Chris D XenForo Developer Staff Member

    I can replicate this more reliably now... I think...

    Slightly different:
    1. Bring up your member card from any one of the posts in this thread.
    2. Open the trophy points overlay.
    3. While the overlay is still open -- this is the important bit -- scroll down to the editor.
    4. Close the overlay any way you like.
    5. Click on your avatar in the quick reply area.
    6. Open the trophy points overlay.
    7. The above screenshots should resemble what happens.
    I think the important factors are that it is an overlay which has previously been opened, cached and closed, and you're scrolling down the page so when the cached overlay opens, it's opening above an element that wasn't on the screen previously.

    This is pretty edge case stuff, I guess, but as you can see if it does happen, it's not pretty.
     
    Daniel Hood likes this.
  9. Brogan

    Brogan XenForo Moderator Staff Member

    Still can't repro it in Chrome.
     
    Andrej likes this.
  10. Chris D

    Chris D XenForo Developer Staff Member

    I can see the cause now.

    The div with the class "xenOverlay"...

    When that overlay originally loads, its given z-index: 9999.

    When the overlay closes (and caches), the z-index is changed to auto.

    When the overlay loads again, the z-index remains at auto. Presumably because it's cached and it effectively just unhides itself. The function that unhides a cached overlay should set the z-index back to 9999.

    That fixes the issue.
     
    Mike and Jeremy like this.
  11. Brogan

    Brogan XenForo Moderator Staff Member

    Yes, confirmed - I can get it to happen in Chrome/Win now.
     
    Chris D likes this.
  12. Chris D

    Chris D XenForo Developer Staff Member

    Video is still processing, but just to avoid any doubt on how to replicate the issue:

     
  13. Martok

    Martok Well-Known Member

    I can confirm this too. Windows 7 / Chrome
     
  14. Chris D

    Chris D XenForo Developer Staff Member

    The bit I highlighted in red is actually not important at all.

    Scrolling doesn't matter.

    It's just relating to the z-index CSS and cached overlays, I think.
     
  15. Jeremy

    Jeremy XenForo Moderator Staff Member

    Very good debugging here! (y) it was driving me insane.
     
    Chris D likes this.
  16. Mike

    Mike XenForo Developer Staff Member

    Looks like the events just made this run in slightly the wrong order, fixed now (locally).
     
    Chris D and Rob like this.

Share This Page