Fixed Non-existent link `settings`

[xfrocks]

This bug is pretty funny. If you disable JavaScript and go edit password, you will be redirected to a non-existent page http://xenforo.com/community/settings



Looks like nobody caught this bug because the edit page uses AutoValidator without data-redirect="yes". Below are the offending lines of code.

class XenForo_ControllerPublic_Account extends XenForo_ControllerPublic_Abstract
{
...
    public function actionSecuritySave()
    {
        ...

        return $this->responseRedirect(
            XenForo_ControllerResponse_Redirect::SUCCESS,
            XenForo_Link::buildPublicLink('settings')
        );
    }
...
}

 

[Mike]

I wonder how that crept through... That was the original name of that area before it became "account".

 

[Chris D]

Glad to see I'm not the only one around here who can't keep up with his conversation messages sometimes, @xfrocks

 

[xfrocks]

Glad to see I'm not the only one around here who can't keep up with his conversation messages sometimes, @xfrocks