• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed Non-existent link `settings`

xfrocks

Well-known member
#1
This bug is pretty funny. If you disable JavaScript and go edit password, you will be redirected to a non-existent page http://xenforo.com/community/settings ;)

Screen Shot 2014-03-24 at 4.51.41 AM.png

Looks like nobody caught this bug because the edit page uses AutoValidator without data-redirect="yes". Below are the offending lines of code.

PHP:
class XenForo_ControllerPublic_Account extends XenForo_ControllerPublic_Abstract
{
...
    public function actionSecuritySave()
    {
        ...

        return $this->responseRedirect(
            XenForo_ControllerResponse_Redirect::SUCCESS,
            XenForo_Link::buildPublicLink('settings')
        );
    }
...
}