1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Non-existent link `settings`

Discussion in 'Resolved Bug Reports' started by xfrocks, Mar 23, 2014.

  1. xfrocks

    xfrocks Well-Known Member

    This bug is pretty funny. If you disable JavaScript and go edit password, you will be redirected to a non-existent page http://xenforo.com/community/settings ;)

    Screen Shot 2014-03-24 at 4.51.41 AM.png

    Looks like nobody caught this bug because the edit page uses AutoValidator without data-redirect="yes". Below are the offending lines of code.

    PHP:
    class XenForo_ControllerPublic_Account extends XenForo_ControllerPublic_Abstract
    {
    ...
        public function 
    actionSecuritySave()
        {
            ...

            return 
    $this->responseRedirect(
                
    XenForo_ControllerResponse_Redirect::SUCCESS,
                
    XenForo_Link::buildPublicLink('settings')
            );
        }
    ...
    }
     
  2. Mike

    Mike XenForo Developer Staff Member

    I wonder how that crept through... That was the original name of that area before it became "account".
     
    Chris D and xfrocks like this.
  3. Chris D

    Chris D XenForo Developer Staff Member

    Glad to see I'm not the only one around here who can't keep up with his conversation messages sometimes, @xfrocks :)
     
  4. xfrocks

    xfrocks Well-Known Member

    :oops:
     

Share This Page