Not a bug Finders not returning false on empty/non-existent result

[Snog]

Affected version

2.1

Take this example where 687 is a non-existent category ID:

$mediaItemFinder = $this->finder('XFMG:MediaItem')
            ->where([
            'category_id' => 687
        ]);

$mediaIds = $mediaItemFinder->pluckFrom('media_id')->fetch(1000);

if(!$mediaIds)
{
    echo 'Nope'; die();
}
else
{
    print_r($mediaIds); die();
}

Will always return
XF\Mvc\Entity\ArrayCollection Object ( [entities:protected] => Array ( ) [populated:protected] => 1 )

 

[Chris D]

That's correct.

You can either convert the object to an array:

if (!$mediaIds->toArray()

Or check if there are any entries:

if (!$mediaIds->count())

 

[Snog]

That's correct.

You can either convert the object to an array:

if (!$mediaIds->toArray()

Or check if there are any entries:

if (!$mediaIds->count())

I could have sworn they use to return FALSE on empty or not found.

Might want to change your code in XFMG then

$mediaIds = $mediaItemFinder->pluckFrom('media_id')->fetch(1000);
if (!$mediaIds)
{
   return $this->complete();
}