So, I went to update to beta 3. And.. my method was to ..
1) Rename old folder
2) Move the "upload" folder in place
3) Start moving data, internal_data, config.php and my hacks to the new folder
So.. you might think, why don't I overwrite? One is security, Second is coherence. After countless vb installations where for some random reason only 1 file would not upload, I decided to go the way of extracting the zip in the server and promoting the upload directory to base installation. Also, that way I wipe anything that could be there that is alien.
So .. what happened?
First of all, I didn't shutdown apache (silly me), that meant that the users could still try to enter the site. No bid deal, I thought. I was wrong.
1) As soon as I moved internal_data, somehow install-lock.php dissapeared
2) Since the users were redirected to the upgrade page, after I uploaded the config.php they were given the option to reinstall the forum including wiping the database (because I included config.php)
3) I could not fix it fast ... because I didn't know how to resume the upgrade process. The request index.php?upgrade redirected me to index. Figuring out that the lock disappeared was not fun
I am pretty sure that some people here would like to make this my fault for not uploading/merging contents instead. But I don't like doing that for the reasons explained. And I do have some suggestions:
1) Upgrade should not rely only on internal-lock, if my database is a valid xf one, I have the directories chmoded and in place .. I should be able to resume the upgrade somehow.
2) install-lock is magically removed, why? So, that means that if for some reason I delete config.php (say I rename it, and then rename it back, and that can happen), any user can go to /install and wipe my whole forum
3) Add a "master password" (vb used the customer id) to the install process. At least, if this accident happens the user cannot continue because he does not have the number
Myself .. I have added .htaccess in place, and next time I will shutdown apache, move everything in place and then start it up again.