1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Implemented Make _getNotableMembers extensible

Discussion in 'Closed Suggestions' started by Lior., Oct 4, 2014.

  1. Lior.

    Lior. Well-Known Member

    Right now, the _getNotableMembers defines the available notable members types, then fetches the users and returns the result.

    This makes it impossible to extend the notable members page and add more types of notable members.

    Edit: Actually, just noticed that the function returns false if the type doesn't exist in the defined types map, so it's actually possibly to extend it. Still probably not the best design.
     
  2. Mike

    Mike XenForo Developer Staff Member

    It is extendable -- you can react if it's the type you're after and return the default/parent version otherwise.
     
    Chris D likes this.
  3. Chris D

    Chris D XenForo Developer Staff Member

  4. Lior.

    Lior. Well-Known Member

    Yep, it was my bad, don't know what I was thinking :oops:
     

Share This Page