1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Links color in admincp footer

Discussion in 'Resolved Bug Reports' started by rellect, Aug 15, 2015.

  1. rellect

    rellect Well-Known Member

    I noticed that (visited) links in footer suddenly have a different color

    Untitled.png

    Pretty sure the color wasn't changed based on visited state prior to xf1.5
     
    Lazek likes this.
  2. Chris D

    Chris D XenForo Developer Staff Member

    Just compared, that link used to have the "concealed" class, now it doesn't.
     
  3. Mike

    Mike XenForo Developer Staff Member

    It intentionally doesn't now.

    But you'll note it only displays like that on one page.
     
  4. Mike

    Mike XenForo Developer Staff Member

    I think this is a Chrome bug. I can't reproduce it in FF or IE. In Chrome, it also only happens on the main ACP index page and not in all cases. I can reproduce it here but not on my test forum.

    It's not related to inherit -- the color is just being ignored, even with !important. The text decoration is being applied though, so the CSS isn't being skipped. I'm not sure if we can boil this down to a consistent test case though (to report to them).
     
  5. rellect

    rellect Well-Known Member

    I'm able to reproduce this in other pages as well.
    It seems the general rule for `a:visited` has higher priority and therefore it inherits the color from it.

    I was able to solve that by replacing
    HTML:
    #footer a:link
    {
        color: inherit;
        text-decoration: underline;
    }
    With
    HTML:
    #footer a:link,
    #footer a:visited
    {
        color: inherit;
        text-decoration: underline;
    }
    Or simply
    HTML:
    #footer a
    {
        color: inherit;
        text-decoration: underline;
    }
     
    Lazek, Mike and Moshe1010 like this.
  6. Mike

    Mike XenForo Developer Staff Member

    Very good catch! :) I've fixed this now.

    In hindsight, it's clear in the spec that :link and :visited are mutually exclusive (though the name may not make it clear), but the developer tools in each browser don't seem to reflect this accurately, which totally threw me off.
     
    Lazek and rellect like this.

Share This Page