Is XF 1.5 compatible with PHP 7.3?

[Alpha1]

Are there any deprecations or other issues with PHP 7.3?
Has anyone tried yet?

 

[Chris D]

The biggest unknown at this point would be that they have moved from the legacy PCRE to PCRE2.

We haven't tested it, yet, and may not do until it is stable. Of course, there's no guarantee that any fixes required would be made in XF 1.5 though we would certainly be aiming to make 2.0 compliant at the very least.

 

[Kirby]

There seem to be a few issues related to control structures, but nothing dramatic.

phpcs -p /xenforo1.5.22 --standard=PHPCompatibility --extensions=php

FILE: /xenforo1.5.22/library/XenForo/Importer/SMF.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
1075 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
-----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /xenforo1.5.22/library/XenForo/Importer/vBulletin.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
341 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
345 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
585 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
594 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /xenforo1.5.22/library/XenForo/Importer/IPBoard40x.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
147 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
151 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
606 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /xenforo1.5.22/library/XenForo/Importer/IPBoard.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
 334 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
 343 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
1071 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
-----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /xenforo1.5.22/library/XenForo/Importer/PhpBb3.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
234 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
528 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /xenforo1.5.22/library/XenForo/Locale.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 21 WARNINGS AFFECTING 21 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
201 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
202 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
205 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
206 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
209 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
212 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
213 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
214 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
215 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
218 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
219 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
222 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
223 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
226 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
227 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
228 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
229 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
232 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
235 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
238 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
246 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /xenforo1.5.22/library/Zend/Pdf/FileParser/Font/OpenType.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
889 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
908 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
920 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /xenforo1.5.22/library/Zend/Feed/Entry/Atom.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
106 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /xenforo1.5.22/library/Zend/Reflection/File.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
349 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
357 | WARNING | Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3.
----------------------------------------------------------------------------------------------------------------------------------------------------

This scan was done against XenForo 1.5.22

 

[rdn]

This scan was done against XenForo 1.5.22

Using this script?
https://github.com/squizlabs/PHP_CodeSniffer

 

[Kirby]

Exactly.

 

[DragonByte Tech]

phpcs -p /xenforo1.5.22 --standard=PHPCompatibility --extensions=php

Using this script?
https://github.com/squizlabs/PHP_CodeSniffer

Thanks for this tool, I'm going through all of my products to make sure there aren't any problems


Fillip

 

[eva2000]

The biggest unknown at this point would be that they have moved from the legacy PCRE to PCRE2.

We haven't tested it, yet, and may not do until it is stable. Of course, there's no guarantee that any fixes required would be made in XF 1.5 though we would certainly be aiming to make 2.0 compliant at the very least.

Hoping test starts soon. FYI, PHP 7.3.0 GA Stable is coming out today - very speedy version from my benchmarks https://community.centminmod.com/threads/php-7-3-vs-7-2-vs-7-1-vs-7-0-php-fpm-benchmarks.16090/

 

[Chris D]

PHP 7.3 compatibility has been in place for a while so will be ready for the next releases (likely next week).

 

[eva2000]

PHP 7.3 compatibility has been in place for a while so will be ready for the next releases (likely next week).

oooh looking forward to taking advantage of the speed