Fixed Invalid unset choice option

[truonglv]

Affected version

2.2.9

In the file XF\Template\Templater.php line 5380 it seems trigger invalid unset.

if (isset($choice['_type']))
{
   $type = $choice['_type'];
}
else
{
   $type = 'option';
}
unset($choice['_type']);

 

[Old Nick]

I don't know if it's a bug but the code is the same in 2.2.9

 

[truonglv]

I don't know if it's a bug but the code is the same in 2.2.9

I just checked with version 2.2.9. It still effected.

 

[Jeremy P]

I don't think this should be problematic, but it's sorted in 2.2.12 nevertheless.