Fixed Image attachments rotated since the update

Interesting... that sample image bugs out on 2.3.7 but not 2.3.6 as noted.
But, I can't get this to repeat with other test images with a similar orientation change or instruction in set in the exif data.
 
Ok, I think I found the culprit.

./src/XF/Http/Request.php
This file was changed as noted in the screenshot below.

1752940373067.webp

Left: 2.3.6
Right: 2.3.7

A dirty test by replacing the new 2.3.7 file with the original 2.3.6 version showed that the orientation on that sample image provided worked as people expected.

Not a developer, so move at your own risk. @Chris D or @Jeremy P would need to confirm the background here.
 

Attachments

  • 1752940157538.webp
    1752940157538.webp
    12.5 KB · Views: 35
In the message editor, the behavior varies depending on whether you use the icon marked in green in the screenshot to insert images or the button marked in red. In my test, it worked correctly with the green icon (image not rotated). With the red button, I ended up with images rotated by 90° or 180°, but also some images that were correctly aligned.

1752956764181.webp

Copy and paste to a message works fine.

When uploading to the gallery, the same applies as for the button marked in red. It ended up with images rotated by 90° or 180°, but also some images that were correctly aligned.

Using Edge Browser or Safari, for example, makes no difference.
 
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.8).

Change log:
Fix an issue where EXIF orientation would be set when already adjusted client-side
There may be a delay before changes are rolled out to the XenForo Community.
 
I was awaiting the patch or at least the approval of the code edit. I guess we have to go with the unauthored dirty fix?
 
Last edited:
Yeah, hopefully they will issue a statement soon, as image uploading is kinda vital for a forum! If you could easily revert to the 2.3.7 I would, as this version doesn't seem to have given any noticable benefits but has broken this.
 
Yeah, hopefully they will issue a statement soon, as image uploading is kinda vital for a forum! If you could easily revert to the 2.3.7 I would, as this version doesn't seem to have given any noticable benefits but has broken this.
Reverting would be "easy" if I was on 2.3.6 currently, since that file would be handy in a backup.

Instead, I'm planning 2.2 > 2.3. Having 3.4m existing attachments means that function is beyond critical for future posts.
 
Back
Top Bottom