Fixed Image attachments rotated since the update

[beerForo]

Correct. The image is technically upside down and 180 is the correction not being honored.

 

[ENF]

Interesting... that sample image bugs out on 2.3.7 but not 2.3.6 as noted.
But, I can't get this to repeat with other test images with a similar orientation change or instruction in set in the exif data.

 

[ENF]

Ok, I think I found the culprit.

./src/XF/Http/Request.php
This file was changed as noted in the screenshot below.



Left: 2.3.6
Right: 2.3.7

A dirty test by replacing the new 2.3.7 file with the original 2.3.6 version showed that the orientation on that sample image provided worked as people expected.

Not a developer, so move at your own risk. @Chris D or @Jeremy P would need to confirm the background here.

 

[Paul B]

It's related to this: https://xenforo.com/community/threa...tools-destroys-exif-data.230738/#post-1744224

 

[Suzanne O]

Ok so i'll have to look out for that.
At the moment we've had no issues.
I'm going to pinch that link you gave @Paul B and post it on my forum just in case my members are having issues.

 

[beerForo]

@ENF @Paul B thanks for the detective work, will look forward to a patch (or swap files if recommended).

 

[mph]

In the message editor, the behavior varies depending on whether you use the icon marked in green in the screenshot to insert images or the button marked in red. In my test, it worked correctly with the green icon (image not rotated). With the red button, I ended up with images rotated by 90° or 180°, but also some images that were correctly aligned.



Copy and paste to a message works fine.

When uploading to the gallery, the same applies as for the button marked in red. It ended up with images rotated by 90° or 180°, but also some images that were correctly aligned.

Using Edge Browser or Safari, for example, makes no difference.

 

[PASS]

Same here. @ENF post helped me do a dirty fix. No more rotated images. Now I have to live with this until Xenforo puts out a patch.

 

[beerForo]

So the fix is edit the file or use the old file? This works and does not affect anything else?

 

[PASS]

So the fix is edit the file or use the old file? This works and does not affect anything else?

I edited the new file because it has updated code for other things.

 

[beerForo]

Right, so it looks like the word Extended is missing, that is the bug? Thanks

 

[Mr Lucky]

So the fix is edit the file or use the old file? This works and does not affect anything else?

This is my fix:

 

[woody]

Grand plans to finally update from 2.2 to 2.3 on Tuesday, but my site averages 600 new attachments a day....looks like I wait until this gets corrected, official-like...

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.8).

Change log:

Fix an issue where EXIF orientation would be set when already adjusted client-side

There may be a delay before changes are rolled out to the XenForo Community.