Fixed Favicon for links

[zTurko]

Affected version

XF 2.1 Beta 2

Hello,

Favicons is not displayed and displays a 404 error

Here is the error for favicon links :

 

[Mike]

We would need to know the actual link you embedded, as we pull the favicon URL from the site directly. If they don't provide the correct URL, this would be expected.

 

[zTurko]

I did a test here it does not work: https://xenforo.com/community/threads/test-favicon-links.156961/

 

[Mike]

The first example there is roughly expected, at least if you're using the image proxy. They use an icon (ICO) based favicon. The image proxy doesn't support this file type.

The latter case does look like it may be a bug as when I test unfurling, the URL doesn't appear to have canonicalized as expected.

 

[XF Bug Bot]

Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in a future XF release (2.1.0 Beta 3).

Change log:

Use correct function to attempt to convert relative favicon unfurls to absolute URLs.

Any changes made as a result of this issue being resolved may not be rolled out here until later.