Easy User Ban by Siropu [Paid] 1.4.4

[Siropu]

Will look into it.

 

[Freelancer]

Thanks!

 

[Siropu]

Siropu updated Easy User Ban by Siropu with a new update entry:

Improvements & Bug Fix

Added option to post thread notifications for warning bans.
Fixed a bug with banned avatar crop offset position.
Fixed a bug in quick unbanning.

A new phrase has been added for quick unbanning confirmation message.

Read the rest of this update entry...

 

[dutchbb]

This phrase:

{user} has been banned by the System for accumulating warning points

Would be better as (i think):

{user} has been banned by {moderator}

Or:

{user} has been banned by {moderator} with warning points



Because in the thread notification you already have reason stated in the thread -> Rules Violations

This differs from a direct ban (if not same sentence is used).

 

[Siropu]

Would be better as (i think):

{user} has been banned by {moderator}

The ban is triggered by the warning points, not by moderator so moderator data isn't available.

 

[Freelancer]

Siropu updated Easy User Ban by Siropu with a new update entry:
Improvements & Bug Fix
Read the rest of this update entry...

@Siropu: It seems like you fixed it for cropping but not for x-Axis y-Axis Offset. It fixed a few avatar positions but not all. Could you please have another look into it?

 

[Siropu]

There is avatar_crop_x and avatar_crop_y which are cleared for banned users. Are you using any add-ons that changes how avatar works? Because in my tests I don't see any issues.

 

[Freelancer]

I use Nobitas "Avatar Maker" add-on, but that only influences user profile avatars that are not set. It makes a two letter avatar image from the user name, if the user has not uploaded an avatar. I did deactivate it for testing and it had no effect.

 

[Siropu]

I'm sorry, I can't reproduce it.

 

[SAS1024]

@Siropu, can this addon create ban thread notification with author of this thread = author of the ban? Or it can only create threads with predefined user as author?

 

[Siropu]

No, it's a predefined user.

 

[Freelancer]

I'm sorry, I can't reproduce it.

Can you insert something that overrides the avatar position to be always left: 0, top: 0....?

 

[Siropu]

I've already unset avatar_crop_x and avatar_crop_y for banned users. Do you have any other add-ons that overwrites helperAvatarCropCss function?

 

[Freelancer]

I've already unset avatar_crop_x and avatar_crop_y for banned users.

Strangely that helped, but only with part of the avatars. Some still have Left, Top attributes.

Do you have any other add-ons that overwrites helperAvatarCropCss function?

No, not any beside that Nobita add-on which did have no effect when deactivating it.

 

[Siropu]

If the problem is with some add-ons, I don't know what you can do about that. Try changing the Callback Execution Order to 1 in Development > Code Event Listeners > Easy User Ban > init_dependencies
You have to enable debug mode first. Or you can change execution order in the xml file directly and run the upgrade after.

 

[Freelancer]

If the problem is with some add-ons, I don't know what you can do about that.

I am sorry, that was a brainfart. I totally meant "AVATARS" not "add-ons".... your update helped with some of the avatars but not all. Some still have the top:, left: properties set to something other than zero.

 

[Siropu]

That's strange. I can't find any other options than those two that I've unset.

 

[dutchbb]

Ban with warning points thread gives the wrong Ban End

Users got a perm ban but a date is stated for a week ban. Info in the banned members list is correct.

 

[Siropu]

I've done a test and for me it shows
Ban Ends: Never

The code verifies if there is a date or not so I don't see how that could happen.

 

[dutchbb]

I will try to find out why this is happening. For some reason it is stating 1 week ban (what we have after 5 points). I tested this by giving 10 points at once.