digitalpoint
Well-known member
After I asked, I realized it's kind of pointless to ask because I'm going to be hitting a different data center/cache than you are.
A real pain to debug because everyone sees something different.
![[DigitalPoint] App for Cloudflare®](/community/data/resource_icons/8/8750.jpg?1692633961){kind=icon}
[DigitalPoint] App for Cloudflare® 1.8.2
- Thread starter digitalpoint
- Start date
A real pain to debug because everyone sees something different.
Nicolas FR
Well-known member
I will leave this option disabled for now.After I asked, I realized it's kind of pointless to ask because I'm going to be hitting a different data center/cache than you are.
A real pain to debug because everyone sees something different.
benFF
Well-known member
Yes, with the xf addon option we have.
IPS do it differently as they use plupload. Their method is to append each chunk to the output file as it comes in, rather than wait until the end to join them all together.
Sirmadsen
Active member
Right, I need to do some testing before moving platform all together. Worst case I might have to limit file sizes to 5GB.
Would you say plupload is the better alternative here as it sounds to me appending as it comes in would be less time consuming for the end process?
benFF
Well-known member
So we don't derail this thread, I've posted that up on the chunked addon thread. I didn't look at the existing code, but it might be a simple switch
It doesn't really matrer which "upload component" is being used, what does matter is processing on server side.
Ideally, chunks should be saved to storage as-is and the storage should reconstruct the original once all chunks have been uploaded.
S3 does support this and Flow.js (the "upload component" used by XenForo) does allow uploading chunks, all that is missing is come code on XenForo side to "glue" Flow.js and the S3 driver.
@digitalpoint
As I can't fully test this on iolabs.io (and I don't use CloudFlare):
Does guest caching work correctly with Advanced Cookie Consent, eg. if a guest that does accept 3rd party cookies accesses a currently uncached but cachable page that has an embedded youtube video and another user that does not accept 3rd party cookies accesses the page afterwards (and does get a hit from cache) - would the second user still get the consent required message instead of the actual video?
As far as I can see having cookie
As I can't fully test this on iolabs.io (and I don't use CloudFlare):
Does guest caching work correctly with Advanced Cookie Consent, eg. if a guest that does accept 3rd party cookies accesses a currently uncached but cachable page that has an embedded youtube video and another user that does not accept 3rd party cookies accesses the page afterwards (and does get a hit from cache) - would the second user still get the consent required message instead of the actual video?
As far as I can see having cookie
xf_consent doesn't set cache to bypass and you also don't seem to have any server side code to deal with this - I therefore think this would not work correctly.
digitalpoint
Well-known member
Yep, probably not in that scenario.
digitalpoint
Well-known member
Cookie consent stuff isn't at the top of my priority list if that's your question? I'm sure it could be worked out, but no plans to as of this second. That's not to say I won't in the future, just that as of this exact moment in time, it's not something I'm working on (or care about).Thats what I thought
Do you have any plans to fix this (after all this does make Advanced Cookie Consent pretty useless, doesn't it?) and if so: How?
If you don't even use Cloudflare, I'm curious why you even care so much since you can't use it? I believe XenForo has a guest page caching system built into it if you aren't needing or wanting edge caching.
AndrewSimm
Well-known member
XFMG data went pretty smooth
digitalpoint
Well-known member
Mmmm... ya I don't know about that one. It could be done in theory, but then you are talking about breaking away from XenForo's built-in method to update CSRF tokens so we can also pass in the page the user is on and store that to the session activity.
Do you have an actual use case for it besides just having a bigger number for "guests online"?
Wildcat Media
Well-known member
Just curious...I set up XFMG in my config.php, but put it in a separate bucket (as a test), although I could use the internal_data/attachments bucket with no issues. With the test upload, the image showed up properly. But I also noticed that existing images in the gallery were still appearing, despite not having migrated any files over. I don't know if that's correct behavior or not.
Looking in the local internal_data/xfmg subdirectories, the new gallery item is not present, but is present in the R2 bucket. So the new gallery items are being saved in the bucket.
I only want to see where the various files are ending up before I jump into this head first...and wasn't sure if the forum's existing attachments and gallery items were going to "break" if I set up the buckets and still had yet to migrate the existing local files over to the bucket.
AndrewSimm
Well-known member
I have a bucket named internal-data which has internal_data/attachments/. Once I setup my config file I used rclone to move the images over. I now have an attachment folder and xfmg folder in the internal-data bucket.
I am not sure why existing images would still appear. Use inspector to see what links are being used for the images.
Code:
rclone copy internal_data/xfmg r2:internal-data/xfmgI am not sure why existing images would still appear. Use inspector to see what links are being used for the images.
digitalpoint
Well-known member
Are you looking at the thumbnails maybe rather than the originals? Those go to data (directory or bucket).
Wildcat Media
Well-known member
I've clicked through to what should be the full images. Thumbs, yes, are still on the server. I'm migrating that directory last.
These are for an older image not migrated. I only have my most recent gallery image in any of the R2 buckets--everything else is still local.
Full:
<img class="fancybox-image" src="/media/little-yikes.3/full?d=1671025601">
Thumbnail:
<img class="xfmgThumbnail-image" src="/data/xfmg/thumbnail/0/3-946f7ddb9a390e216a981455dfde9781.jpg?1671025348" loading="lazy" width="300" height="300" alt="Little Yikes">
Looks the same for my test upload:
Full:
<img class="fancybox-image" src="/media/why-break-on-track.47/full?d=1673665033">
Thumb:
<img class="xfmgThumbnail-image" src="/data/xfmg/thumbnail/0/47-2d029a33f6061b48c82cbe7060135172.jpg?1673664999" loading="lazy" width="300" height="300" alt="Why break on track...">
That is what I expect also. My test above was more out of curiosity--I may try migrating the entire gallery (there are not many items) to see if anything breaks in the meantime. Not a big deal as I can easily move them back with rclone if I need to.
AndrewSimm
Well-known member
Do you have your external data provider configured?
Here is what my thumbnails look like:
HTML:
<img class="xfmgThumbnail-image" src="//data.canesinsight.com/xfmg/custom_thumbnail/0/22-217359bcc526a8da3d20ebe4426acb0d.jpg?1671244125" loading="lazy" width="322" height="241" alt="Miami Flips DL Joshua Horton + Transfer Portal News & Reactions & The Bank | Canes In Sight Podcast">edit: oops guess they go in data. Forgot internal won't show in the code.
Wildcat Media
Well-known member
Yep, got that in config.php, and all the API tokens are set up. If I go into the R2 configuration in the Cloudflare add-on, and try to activate one of the two options, I do get a choice of my existing R2 buckets, and everything else in the Cloudflare add-on is appearing and working OK.
Unless I'm missing a step. Although the one media gallery item in the bucket is also displaying properly (and the file is appearing in the bucket), so something is working right.
I just find it interesting that the remaining images in the gallery didn't break after making the change.
And then I start wondering if Cloudflare is caching those older images. The oldest was dated back to mid December of 2022, and it loaded with no issues. But...
Maybe I'll stop being curious and just go ahead and migrate everything over...
