Fixed Deleting banned spammer leaves orphaned entries in spam cleaner log

[Kirby]

Affected version

2.0.1

When a user that was banned though spam cleanup is being deleted, the entries in spam cleaner log are being kept.

When clicking restore, this causes a somewhat strange message to be displayed:

 

[Chris D]

Interestingly this has actually existed as a bug in XF 1.x probably since forever, and no one has ever brought it up. Additionally in XF1, although the content is restored, it presents an error message so we may well want to make a couple of changes there too.

 

[Chris D]

We've made some changes here in both XF1 and XF2 so this now behaves better with regards to deleted users.