1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Lack of Interest Customized Flag for templates and phrases

Discussion in 'Closed Suggestions' started by xf_phantom, Jul 3, 2013.

  1. xf_phantom

    xf_phantom Well-Known Member

    We really need a new flag for phrases and templates, to be able to mark them as customized, so they won't be touched while an addon upgrade.
    (atm xenforo just deletes everything from the addon)


    PHP:
    if ($overwriteLanguageId)
         {
           
    $db->delete('xf_phrase',
             
    'language_id = ' $db->quote($overwriteLanguageId)
               . (
    $limitAddOnId != '' ' AND addon_id = ' $db->quote($limitAddOnId) : '')
           );

           
    $existingPhrases $this->_getPhraseModel()->getAllPhrasesInLanguage($overwriteLanguageId);
         }

    //or

    $db->delete('xf_phrase''language_id = 0 AND addon_id = ' $db->quote($addOnId));


    Current Problems:
    Custom Translations:
    All customized phrases will be replaced again by the next addon or translation upgrade. (in combination with http://xenforo.com/community/threads/languagemodel-importlanguagexml.53984/ it's causing big problems with custom translations :D )

    Custom templates & Phrases for addons
    Just think about addons like xenporta, which include "blocks" and probably a own export/import inteface.
    The additional blocks aren't allowed to be associated with xenporta, because the templates would be deleted by each xenporta update.
    But it would also be a horrible idea to create a new addon for each block =>results in templates and phrases which aren't associaetd with any addons.
    Which could lead to MANY orphan data
     
    Last edited: Jul 3, 2013
  2. xf_phantom

    xf_phantom Well-Known Member

    I know i talked with @Mike about this in the past, but i had to post it as suggestion, because
    is really a BIG PAIN if you have a non english board with many addons and custom translations from different translators and you need to customize some phrases yourself.
     

Share This Page