Fixed Conversations and alerts counter issue

[Wave]

Affected version

2.1.1

If marked a conversation as unread, it must be opened twice to be marked as read again and the counter get updated. I can reproduce this issue here.

Alerts count get updated when go back to the previous page but haven't updated when go forward. I think its a cache issue.

 

[Chris D]

Can we have some browser details, please and some more specific reproduction steps?

In Chrome I can't seem to reproduce what you've mentioned here. We did make some changes in this area today, but will need to know how to solidly reproduce the issue.

 

[Wave]

Steps to reproduce:

• The conversation must contain two pages at least
• Open the conversation and mark it as unread
• Go to forum index
• Open the conversation again
• Go to forum index again then you'll notice that the conversation still marked as unread and you must open it once again to be marked as read

Since you manually marked it as unread, it make sense to be marked as read first time you open it.

 

[Chris D]

Ahh. This isn't anything to do with caching.

The first time you open the conversation after marking it as unread, you open the conversation on the first page. The second time you open it, you end up on the last page.

We will only mark an unread conversation as fully read when you have viewed the last page. So that's what you're seeing.

That said, I have noticed that we set the last_read_date to 0 and arguably that isn't totally necessary. It has always been like that, but technically if we didn't change that to 0, then I think clicking the unread conversation would take you to the last message in the conversation which should solve the problem.

Leave it with us.

 

[Wave]

Correct. The cache issue with alerts as I said in the original post.

To view this content we will need your consent to set third party cookies.
For more detailed information, see our cookies page.

Accept third party cookies

 

[Steve F]

That said, I have noticed that we set the last_read_date to 0 and arguably that isn't totally necessary. It has always been like that, but technically if we didn't change that to 0, then I think clicking the unread conversation would take you to the last message in the conversation which should solve the problem.

Does that mean this would likely work how my suggestion is described once changed? Or am I reading that totally wrong?

 

[Chris D]

I actually considered that as I was typing that response. It's kind of different because you're talking about where you land when you have previously read the conversation and it is marked as "read". I'm talking about where you land if the conversation is unread (or more specifically, where you land when you have read it, but then marked it as unread again).

That said, I'm definitely not against your suggestion. It makes sense, but it's a different change that is required.

 

[Chris D]

Ahh. This isn't anything to do with caching.

The first time you open the conversation after marking it as unread, you open the conversation on the first page. The second time you open it, you end up on the last page.

We will only mark an unread conversation as fully read when you have viewed the last page. So that's what you're seeing.

That said, I have noticed that we set the last_read_date to 0 and arguably that isn't totally necessary. It has always been like that, but technically if we didn't change that to 0, then I think clicking the unread conversation would take you to the last message in the conversation which should solve the problem.

Leave it with us.

I've made this change, and in conjunction with the change from this suggestion I think this works better now. We no longer reset the last read date so typically when you navigate to the conversation it will no longer be to the first page and therefore will mark the conversation read instantly.

Correct. The cache issue with alerts as I said in the original post.

To view this content we will need your consent to set third party cookies.
For more detailed information, see our cookies page.

Accept third party cookies

I think this is solved now by virtue of the changes we made last month. Please create a new bug report if you can still reproduce this.

 

[Wave]

I've made this change, and in conjunction with the change from this suggestion I think this works better now. We no longer reset the last read date so typically when you navigate to the conversation it will no longer be to the first page and therefore will mark the conversation read instantly.

There is another issue when mark the conversation as unread.

Steps to reproduce:

• The conversation must contain more than two pages
• Open the conversation and mark it as unread
• Every time you open the conversation from navigation menu it will redirect you to the next page and you must visit all pages before the conversation get marked as read

 

[Chris D]

That's part of what has been changed. You won't see the changes here yet, though.