Classifieds [Paid] 1.2.0
- Thread starter Z61
- Start date
ichpen
Well-known member
It has been a really long time since we got an update on it, there's a few things that need improvement for sure. It still works mostly though.
Frode789
Well-known member
Definitely. Unresolved bug reports for over a year and no support, he ignores questions from users here and on his forum.
It's abandonware, stay away if you don't like throwing money out of a window. There are several good alternatives.
viper357
Well-known member
I have it running on my forum, no issues whatsoever.
Brian Jones
Active member
Bobs Classified Ads System (CAS) works very well if this dev has poofed.
Frode789
Well-known member
XFA has a marketplace/shop addon. https://xenforo.com/community/resources/xfa-rm-marketplace-shop-xf2.6064/
Bob has a classifieds addon. https://xenaddons.com/store-products/cas-standard-license/
Andy has a simple classifieds addon. https://xenforo.com/community/resources/classified-forums.7548/
XFA
Well-known member
We also have a forum sales add-on which provides sort of classifieds features.
[XFA] Forum Sales - XF2
Description Have you ever searched for a simple sale/classifieds solution allowing your user to sell their stuff directly from the forums ? Forum Sales is the solution ! Through a few additional fields to fill-in upon thread creation or edit...
xenforo.com
NealC
Well-known member
Main one I have is if you enter a price such as "11,012.00" the cost shows as 11 I believe. Reported some time ago but never fixed. Major issue if people can't list their products properly with a major error in cost for the listing.For some of the smaller bugs I've been fixing them myself. What are the main issues people have now, perhaps I already squished it
benFF
Well-known member
That seems like a pretty simple fix.
I see though that some countries use 11012,00 so it will have to allow for that (ie not just remove the , which would work for the first example!)
benFF
Well-known member
Had a quick look at the code on the train going home and this is due to the float filter being run on the price - it creates a number from string, but will stop when it reaches an invalid char (which in this case is the ,)
Quickest solution is just to remove commas from submitted prices (if the backend specified decimal point character isn't a comma)
\Z61\Classifieds\Service\Listing\ListingShared.php
Find:
PHP:
public function setPrice($price, $currency)
{
$this->listing->price = $price;
$this->listing->currency = $currency;
}Change:
PHP:
public function setPrice($price, $currency)
{
if (\XF::language()['decimal_point'] != ',' && strpos($price, ',') !== false)
$price = str_replace(",", "", $price);
$this->listing->price = $price;
$this->listing->currency = $currency;
}I'd even be tempted to say this is a xenForo bug - as if this is commonly used (in the US?) then the filter should account for this.
benFF
Well-known member
On further inspection - this "bug" happens with other official XenForo addons too (Resource Manager for example) - the backend methods used for both are the same.
I'm curious why the input allows text at all though - in fact you can ignore my edits above and simple change the template:
Find:
Change:
Now it won't let you put in , (or anything that isn't a number) even if you wanted to
I'm curious why the input allows text at all though - in fact you can ignore my edits above and simple change the template:
z61_classifieds_listing_edit_macros
Find:
Code:
<xf:textbox name="price" value="{{ !empty($listing.price) ? $listing.price : $category.draft_listing.price }}" placeholder="{{ phrase('price') }}" style="width: 120px" />Change:
Code:
<xf:numberbox name="price" value="{{ !empty($listing.price) ? $listing.price : $category.draft_listing.price }}" placeholder="{{ phrase('price') }}" style="width: 120px" />Now it won't let you put in , (or anything that isn't a number) even if you wanted to
benFF
Well-known member
I've packaged up all the changes I've made to my local copy in a new addon:
xenforo.com
Feel free to post other issues to that thread and I'll see if I can get them patched into it too
[FF] Classifieds Enhancements (+ Fixes)
A few useful extensions for NixFifty's Classifieds system - as well as any bug fixes that I spotted. Require prefix Adds a new option in the category edit page to require a prefix for posted items. Linked prefixes Link a classifieds prefix to...
xenforo.com
Feel free to post other issues to that thread and I'll see if I can get them patched into it too
NealC
Well-known member
Should this be reported to XF?On further inspection - this "bug" happens with other official XenForo addons too (Resource Manager for example) - the backend methods used for both are the same.
I'm curious why the input allows text at all though - in fact you can ignore my edits above and simple change the template:
z61_classifieds_listing_edit_macros
Find:
Code:<xf:textbox name="price" value="{{ !empty($listing.price) ? $listing.price : $category.draft_listing.price }}" placeholder="{{ phrase('price') }}" style="width: 120px" />
Change:
Code:<xf:numberbox name="price" value="{{ !empty($listing.price) ? $listing.price : $category.draft_listing.price }}" placeholder="{{ phrase('price') }}" style="width: 120px" />
Now it won't let you put in , (or anything that isn't a number) even if you wanted to
Similar threads
- Suggestion
- Locked
- Question
