Not planned BB Code context not always needed

[Snog]

To my knowledge, the context is not always needed for a BB Code, so I suggest this change...

public function fnBbCode($templater, &$escape, $bbCode, $context = null, $user = null, array $options = [], $type = 'html')

 

[Kirby]

I strongly disagree, wo do need more context - not less:
https://xenforo.com/community/threads/context-for-bb-code-parsing-rendering.133828/

 

[Snog]

I strongly disagree, wo do need more context - not less:
https://xenforo.com/community/threads/context-for-bb-code-parsing-rendering.133828/

In some cases that may be true. But in some cases you don't need any. Setting the default to null simply gives the option of not using it at all.

Which would eliminate needing to set a blank in the template {{ bb_code($my.field, '') }}

 

[Kirby]

I still disagree.

There might be Add-ons dealing with BB code parsing that rely on information about what is being parsed in order to properly support your Code/Add-on, so you should not leave them in the dark - do provide the information what is being parsed.

 

[Chris D]

It's a required argument in all cases so, indeed, it's not really designed to be optional. It should be provided even if it's just an arbitrary string that identifies its purpose or the add-on that calls it.

 

[Snog]

It's a required argument in all cases so, indeed, it's not really designed to be optional. It should be provided even if it's just an arbitrary string that identifies its purpose or the add-on that calls it.

That's my point. An arbitrary string really doesn't do anything. But, I'll abide by it.

Heck, even though I don't see why it's needed, I'll take it all the way {{ bb_code($myarray.field, 'mytype', $xf.visitor) }}

 

[Mike]

Just to follow this up, this is most definitely not planned and changes for the next release require more info about the context: https://xenforo.com/community/threads/context-for-bb-code-parsing-rendering.133828/post-1184663

This context is there for add-ons/customizations and future proofing (such as controlling what tags are allowed separately by content, for example).