AMPXF - AMP for Xenforo 2

AMPXF - AMP for Xenforo 2 [Paid] 1.4.9

No permission to buy (€50.00)
Hi @mazzly I just upgraded to RC3 there and I'm suddenly producing a lot of errors:
View attachment 245792
Yes I was a bit afraid of this when making support for 2.1 along with 2.2 as it now uses the default "thread_view" which other addons can also mess with, so other addons will now add e.g. scripts into the content that needs to be stripped out..

I will have a look at it asap :)
 
Regarding 1.3.2 RC 2 you may be wanna check that. It´s new since installation but comes in the hundreds. Noticing the "get('is_audio')" for the very first time.

Code:
InvalidArgumentException: Accessed unknown getter 'is_audio' on XF:Attachment[1540] src/XF/Mvc/Entity/Entity.php:194


Stack-Trace

#0 src/XF/Mvc/Entity/Entity.php(106): XF\Mvc\Entity\Entity->get('is_audio')
#1 internal_data/code_cache/templates/l8/s7/public/amp_bb_code_tag_attach.php(24): XF\Mvc\Entity\Entity->offsetGet('is_audio')
#2 src/XF/Template/Templater.php(1315): XF\Template\Templater->{closure}(Object(MaZ\AMP\XF\Template\Templater21), Array)
#3 src/addons/MaZ/AMP/XF/Template/Templater21.php(47): XF\Template\Templater->renderTemplate('amp_bb_code_tag...', Array, true)
#4 src/XF/BbCode/Renderer/Html.php(485): MaZ\AMP\XF\Template\Templater21->renderTemplate('public:amp_bb_c...', Array)
#5 [internal function]: XF\BbCode\Renderer\Html->renderTagAttach(Array, 'full', Array, Array, Object(MaZ\AMP\XF\BbCode\Renderer\Html))
#6 src/XF/BbCode/Renderer/Html.php(295): call_user_func(Array, Array, 'full', Array, Array, Object(MaZ\AMP\XF\BbCode\Renderer\Html))
#7 src/XF/BbCode/Traverser.php(61): XF\BbCode\Renderer\Html->renderTag(Array, Array)
#8 src/XF/BbCode/Traverser.php(37): XF\BbCode\Traverser->renderSubTree(Array, Array)
#9 src/XF/BbCode/Traverser.php(20): XF\BbCode\Traverser->renderAst(Array, Object(SV\UserMentionsImprovements\XF\BbCode\RuleSet), Array)
#10 src/XF/SubContainer/BbCode.php(219): XF\BbCode\Traverser->render('[USER=46929]@Fr...', Object(XF\BbCode\Parser), Object(SV\UserMentionsImprovements\XF\BbCode\RuleSet), Array)
#11 src/XF/Template/Templater.php(2035): XF\SubContainer\BbCode->render('[USER=46929]@Fr...', 'html', 'post', Object(SV\ThreadReplyBanTeeth\XF\Entity\Post), Array)
#12 [internal function]: XF\Template\Templater->fnBbCode(Object(MaZ\AMP\XF\Template\Templater21), false, '[USER=46929]@Fr...', 'post', Object(SV\ThreadReplyBanTeeth\XF\Entity\Post))
#13 src/XF/Template/Templater.php(936): call_user_func_array(Array, Array)
#14 internal_data/code_cache/templates/l8/s7/public/post_macros.php(329): XF\Template\Templater->func('bb_code', Array, false)
#15 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(MaZ\AMP\XF\Template\Templater21), Array, Array)
#16 src/addons/MaZ/AMP/XF/Template/Templater.php(71): XF\Template\Templater->callMacro('post_macros', 'post', Array, Array, NULL)
#17 internal_data/code_cache/templates/l8/s7/public/thread_view.php(686): MaZ\AMP\XF\Template\Templater->callMacro('post_macros', 'post', Array, Array)
#18 src/XF/Template/Templater.php(1315): XF\Template\Templater->{closure}(Object(MaZ\AMP\XF\Template\Templater21), Array)
#19 src/addons/MaZ/AMP/XF/Template/Templater21.php(47): XF\Template\Templater->renderTemplate('thread_view', Array, true)
#20 src/XF/Template/Template.php(24): MaZ\AMP\XF\Template\Templater21->renderTemplate('public:thread_v...', Array)
#21 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#22 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:amp_thre...', Array)
#23 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#24 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#25 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#26 src/XF/App.php(2178): XF\Mvc\Dispatcher->run()
#27 src/XF.php(390): XF\App->run()
#28 index.php(20): XF::runApp('XF\\Pub\\App')
#29 {main}

Status of request

array(4) {
  ["url"] => string(64) "/topic/xyz.249439/?amp=1"
  ["referrer"] => bool(false)
  ["_GET"] => array(1) {
    ["amp"] => string(1) "1"
  }
  ["_POST"] => array(0) {
  }
}
 
Regarding 1.3.2 RC 2 you may be wanna check that. It´s new since installation but comes in the hundreds. Noticing the "get('is_audio')" for the very first time.

Code:
InvalidArgumentException: Accessed unknown getter 'is_audio' on XF:Attachment[1540] src/XF/Mvc/Entity/Entity.php:194


Stack-Trace

#0 src/XF/Mvc/Entity/Entity.php(106): XF\Mvc\Entity\Entity->get('is_audio')
#1 internal_data/code_cache/templates/l8/s7/public/amp_bb_code_tag_attach.php(24): XF\Mvc\Entity\Entity->offsetGet('is_audio')
#2 src/XF/Template/Templater.php(1315): XF\Template\Templater->{closure}(Object(MaZ\AMP\XF\Template\Templater21), Array)
#3 src/addons/MaZ/AMP/XF/Template/Templater21.php(47): XF\Template\Templater->renderTemplate('amp_bb_code_tag...', Array, true)
#4 src/XF/BbCode/Renderer/Html.php(485): MaZ\AMP\XF\Template\Templater21->renderTemplate('public:amp_bb_c...', Array)
#5 [internal function]: XF\BbCode\Renderer\Html->renderTagAttach(Array, 'full', Array, Array, Object(MaZ\AMP\XF\BbCode\Renderer\Html))
#6 src/XF/BbCode/Renderer/Html.php(295): call_user_func(Array, Array, 'full', Array, Array, Object(MaZ\AMP\XF\BbCode\Renderer\Html))
#7 src/XF/BbCode/Traverser.php(61): XF\BbCode\Renderer\Html->renderTag(Array, Array)
#8 src/XF/BbCode/Traverser.php(37): XF\BbCode\Traverser->renderSubTree(Array, Array)
#9 src/XF/BbCode/Traverser.php(20): XF\BbCode\Traverser->renderAst(Array, Object(SV\UserMentionsImprovements\XF\BbCode\RuleSet), Array)
#10 src/XF/SubContainer/BbCode.php(219): XF\BbCode\Traverser->render('[USER=46929]@Fr...', Object(XF\BbCode\Parser), Object(SV\UserMentionsImprovements\XF\BbCode\RuleSet), Array)
#11 src/XF/Template/Templater.php(2035): XF\SubContainer\BbCode->render('[USER=46929]@Fr...', 'html', 'post', Object(SV\ThreadReplyBanTeeth\XF\Entity\Post), Array)
#12 [internal function]: XF\Template\Templater->fnBbCode(Object(MaZ\AMP\XF\Template\Templater21), false, '[USER=46929]@Fr...', 'post', Object(SV\ThreadReplyBanTeeth\XF\Entity\Post))
#13 src/XF/Template/Templater.php(936): call_user_func_array(Array, Array)
#14 internal_data/code_cache/templates/l8/s7/public/post_macros.php(329): XF\Template\Templater->func('bb_code', Array, false)
#15 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(MaZ\AMP\XF\Template\Templater21), Array, Array)
#16 src/addons/MaZ/AMP/XF/Template/Templater.php(71): XF\Template\Templater->callMacro('post_macros', 'post', Array, Array, NULL)
#17 internal_data/code_cache/templates/l8/s7/public/thread_view.php(686): MaZ\AMP\XF\Template\Templater->callMacro('post_macros', 'post', Array, Array)
#18 src/XF/Template/Templater.php(1315): XF\Template\Templater->{closure}(Object(MaZ\AMP\XF\Template\Templater21), Array)
#19 src/addons/MaZ/AMP/XF/Template/Templater21.php(47): XF\Template\Templater->renderTemplate('thread_view', Array, true)
#20 src/XF/Template/Template.php(24): MaZ\AMP\XF\Template\Templater21->renderTemplate('public:thread_v...', Array)
#21 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#22 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:amp_thre...', Array)
#23 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#24 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#25 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#26 src/XF/App.php(2178): XF\Mvc\Dispatcher->run()
#27 src/XF.php(390): XF\App->run()
#28 index.php(20): XF::runApp('XF\\Pub\\App')
#29 {main}

Status of request

array(4) {
  ["url"] => string(64) "/topic/xyz.249439/?amp=1"
  ["referrer"] => bool(false)
  ["_GET"] => array(1) {
    ["amp"] => string(1) "1"
  }
  ["_POST"] => array(0) {
  }
}
Ahh yes probably needs its own version of that template for 2.1, I'll whip something up
 
Yes we are (big board).

 
Jonathan,
somehow the ads don´t work for me. wether with the XF AdManager or Siropus AdManager (which is without a doubt the far superior one). Even after 12 hours no sign of an ad. They only show up, when the code is inserted directly into the amp template. TMS says 4/0/0. Anyone out there having the same problem?

@Siropu, I´ll ask it here, so everyone is in the loop: could you may be hook up with Jonathan to provide support for AmpXF ad positions in your Ad Manager (esp. to support criterias like "Element-ID=7" etc.)? I know there is a "Limit depending on page type -> only show on AMP pages" setting, but it seems it isn´t working for AmpXF pages at all.
 
somehow the ads don´t work for me. wether with the XF AdManager or Siropus AdManager (which is without a doubt the far superior one). Even after 12 hours no sign of an ad. They only show up, when the code is inserted directly into the amp template. TMS says 4/0/0. Anyone out there having the same problem?
Could you open a support ticket I will have a look. :)
 
1) Would you be so kind to add screenshots of all options and related pages to https://xenforo.com/community/resources/ampxf-amp-for-xenforo-2.8225/ like other add-ons have.

2) How does advertising setup look like and what placements are supported? Is the standard admin.php?advertising extended in some way?

3) Is amp-analytics supported and is it possible to customize it?

4) What information is sent to your servers exactly? Your Terms and conditions says "AMP Robot can securely interact with the installed addon to share some data" and shows couple of examples, but not the complete and exact list.

5) What does it mean "Other installed addons which might interfere with AMPXF and needs to be handled in code." Are you sending add-ons source code or any other files to your server?

6) Sharing forum data with third party has privacy/GDPR implications. It is also not mentioned in your Privacy policy. Is it possible to disallow it?
 
1) Would you be so kind to add screenshots of all options and related pages to https://xenforo.com/community/resources/ampxf-amp-for-xenforo-2.8225/ like other add-ons have.

2) How does advertising setup look like and what placements are supported? Is the standard admin.php?advertising extended in some way?

3) Is amp-analytics supported and is it possible to customize it?

4) What information is sent to your servers exactly? Your Terms and conditions says "AMP Robot can securely interact with the installed addon to share some data" and shows couple of examples, but not the complete and exact list.

5) What does it mean "Other installed addons which might interfere with AMPXF and needs to be handled in code." Are you sending add-ons source code or any other files to your server?

6) Sharing forum data with third party has privacy/GDPR implications. It is also not mentioned in your Privacy policy. Is it possible to disallow it?
1. Sure I will do so at some later point when I have time. Currently fixing some remaining quirks with the 2.1 version
2. Yes, there are specific Ad positions for the AMP pages.
3. Yes it is enabled by default and will use the Google Analytics id set in XF settings. It also allows custom GA id. Can be modified in template if needed some special things.
4. Exactly those things that are listed in the terms are sent, nothing else.
5. No source code is sent, only the list of other installed addons that might be the cause of some errors/bugs
6. No personally identifiable information is shared to the AMPBot, so there are no GDPR implications.

I think you missed the important part of the terms, looking at your questions 4-6, I will highlight the important part here:

AMP Robot can securely interact with the installed addon to share some data that is used to improve the experience for you and future customers of the addon. This data, will NEVER be shared with any third party, and is used for the purpose of improving the AMPXF experience.

So to summarize: The "shared data" is only things that are directly related to the AMP addon, nothing else.
 
Since you´re in the mood to strip out some unwanted add-on code from the amp-pages, I´ve just activated the Themehouse Q&A again. Guess it´s quite popular in XF 2.1 and unfortunal interferes with amp-pages...erm...disturbing ;)
 
Top Bottom