mazzly
Well-known member
Thanks, appreciate it!
It is almost daily work since November to get it to this state
and it is nowhere ready yet 
AMPXF - AMP for Xenforo 2 [Paid] 2.3.0 Patch Level 3
- Thread starter mazzly
- Start date
It is almost daily work since November to get it to this state
and it is nowhere ready yet 
Chromaniac
Well-known member
just curious about this... how are you handling hotlinked images. or even attached images!
mazzly
Well-known member
add ?amp=1 in the URL when you are visiting a thread.. For best experience do it with a Mobile viewport/size
mazzly
Well-known member
Magics, lube and tears
No all joking aside, they are placed inside a container and set to "fill full space of it" and then that container is limited with css.
I have some plans to try and catch the real dimensions later, but for now this solution works
JulianD
Well-known member
I get redirected to the normal version of the thread. I couldn't find if there was a permission or anything.add ?amp=1 in the URL when you are visiting a thread.. For best experience do it with a Mobile viewport/size
mazzly
Well-known member
hmm that doesn't sound right.. I checked your site and it seems the ServiceWorker is doing some redirecting there.. Do you have some customized Service Worker?
JulianD
Well-known member
No idea. Maybe it's some plugin/theme messing with it. I'll check it out and get back to you.hmm that doesn't sound right.. I checked your site and it seems the ServiceWorker is doing some redirecting there.. Do you have some customized Service Worker?
Last edited:
mazzly
Well-known member
Thanks
JulianD
Well-known member
I got it to work! thank you very much.Thanks
One last question, how am I supposed to enable AMP Auto Ads? I see there's a conditional inside Templater.php to detect if I use the audo ads code. I pasted it into the "After opening of <body>-tag [AMP]" position but the $ampAutoAds variable is not being set.
Maybe I'm doing it wrong, any help would be appreciated!
mazzly
Well-known member
There is actually a bug that I will try to have out a release for still today, where the amp-ad and amp-auto-ads insertions don't happen correctly..
btw in our testing the amp-auto-ads for adsense has not seemed to work at all, but might be good to try and see if it works for you
JulianD
Well-known member
Yeah I'm just running some tests to see what sticks. I will probably use custom ads once I'm sure everything is working fine.There is actually a bug that I will try to have out a release for still today, where the amp-ad and amp-auto-ads insertions don't happen correctly..
btw in our testing the amp-auto-ads for adsense has not seemed to work at all, but might be good to try and see if it works for you
Masetrix
Well-known member
For this purpose I created a template extension. (activate Developers mode...)
Rich (BB code):
$0
<xf:if is="$ampUrl">
<br /><a href="{$ampUrl}"> AMP-Version...</a>
</xf:if>This automatically inserts a link to the AMP version below your logo as soon as it detects an AMP version. You can then deactivate it again when it is no longer needed.
HTh...
mazzly
Well-known member
mazzly updated AMPXF - AMP for Xenforo 2 with a new update entry:
New release 1.1.2
Read the rest of this update entry...
New release 1.1.2
The bug might make your Google Search Console show that some pages are "Valid with warnings", so make sure to go ahead and restart validation for those if you use google search console
- Allow disabling the consent screens for EUGDPR / CCPA under Advanced options
- Fix bug where <head> was missing <amp-ad>-related script
Read the rest of this update entry...
mazzly
Well-known member
The new release should have the fix for ads for you..
Also: the AMP Robot has found some things you can fix
I noticed that your site has a huge amount of reactions/smilies, so the CSS Style goes way over the limit for your site.. I have some plans for how I can remedy some of this, but it might take a while.. In the meanwhile all your pages will likely be "non-valid" AMP..
JulianD
Well-known member
I will try to lower the amount of smilies. There are some old ones that are not used that oftenThe new release should have the fix for ads for you..
Also: the AMP Robot has found some things you can fix
I noticed that your site has a huge amount of reactions/smilies, so the CSS Style goes way over the limit for your site.. I have some plans for how I can remedy some of this, but it might take a while.. In the meanwhile all your pages will likely be "non-valid" AMP..
tonmo
Well-known member
how many do u have? I have many dozens custom. And 5 or 6 custom reactions. No known issues so far.
JulianD
Well-known member
Not that much. But I guess it's the opportunity to get rid of some of the old ones
Similar threads
- Deleted member 184953
- Translation releases [2.x]
