• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Lack of interest Allow uppercase syntax in orderDirection.

#1
Maybe this is my fault. But i think it other developer just make the same mistake.

XenForo/Model/Thread.php line 109

please change to:

if (!isset($fetchOptions['orderDirection']) || $fetchOptions['orderDirection'] == 'desc')

to

if (!isset($fetchOptions['orderDirection']) || strtolower($fetchOptions['orderDirection']) == 'desc')

Maybe there are more positions in different models.

I just want to start a discussion and hope to make it easier for developer to use models in their addons.

Thanks,

Daniel
 

Mike

XenForo developer
Staff member
#2
Moved to suggestions. You'll find that we either use under_score or camelCase names for values like this. Either way "desc" would come out to be the standard value.