1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Alert when you quote yourself

Discussion in 'Resolved Bug Reports' started by Disjunto, Aug 6, 2010.

  1. Disjunto

    Disjunto Well-Known Member

    You receive an alert when you quote yourself, self explanatory really
     
  2. Cezz

    Cezz Well-Known Member

    :( I was just about to test this but looks like you beat me to it... :p
     
  3. Disjunto

    Disjunto Well-Known Member

    the "you were quoted" alert seems to override the "new messages" alert. Which seems good :D
     
  4. Cezz

    Cezz Well-Known Member

    Awesome :D so if you subscribe to a thread you will just get the you were quoted alert instead? YAY
     
  5. Peggy

    Peggy Well-Known Member

    I've never quoted myself I don't think, so I wouldn't have discovered this. Good job.
     
  6. Disjunto

    Disjunto Well-Known Member


    Quick test


    Receive an alert for this?
     
  7. Peggy

    Peggy Well-Known Member

    nope
     
  8. Disjunto

    Disjunto Well-Known Member

    good, don't want them to add that functionality. I edited the quote in after posting.
     
  9. Kier

    Kier XenForo Developer Staff Member

    Doh!! I was actually in the middle of writing that line of code when a call came in, then I forgot what it was for and removed it.

    It's back now ;)
     
    Enigma likes this.
  10. Disjunto

    Disjunto Well-Known Member

    you say it works now then?

    EDIT: Yup, all working now. Nice and quick :D
     
  11. Sami

    Sami Well-Known Member

    Will there be a user setting to turn this thing off? :rolleyes:
     
  12. Kier

    Kier XenForo Developer Staff Member

    I wish all fixes were that simple - it was just a case of taking this
    PHP:
    if (!isset($quotedUsers[$quotedPost['user_id']]) && $quotedPost['user_id'])
    and updating it with
    PHP:
    if (!isset($quotedUsers[$quotedPost['user_id']]) && $quotedPost['user_id'] && $quotedPost['user_id'] != $post['user_id'])
     
    Onimua and Ceri May like this.
  13. Kier

    Kier XenForo Developer Staff Member

    Eventually, I expect so.
     
    Enigma likes this.
  14. Disjunto

    Disjunto Well-Known Member

    wow, now that was some crazy hard code :D
     
  15. Kier

    Kier XenForo Developer Staff Member

    Yeah, made me really struggle ;)
     
  16. Sami

    Sami Well-Known Member

    Nice. I'm not a huge fan of of flashy/flashing things. :)
     

Share This Page