Alert Improvements by Xon

Alert Improvements by Xon 2.10.13

No permission to download
Overview FAQ Updates (68) Reviews (9) History Discussion
ge66 said:
XF2.1, they seem to get that phrase, but is that not just for rating and not for reactions, I have no ratings on my site. The varibles do not have a value: {ratedcontent} {ratings}
Click to expand...
Sent you a version I believe that fixes it for testing
 
Sorry for being daft but what does "summarization" mean and look like? This is like a daily digest alert?
 
It is alert 'grouping' or 'collapsing' it takes a large number of individual alerts for either a post or from a user and "summarizes" it into a single alert entry
 
Xon said:
It is alert 'grouping' or 'collapsing' it takes a large number of individual alerts for either a post or from a user and "summarizes" it into a single alert entry
Click to expand...
So if 10 people "like" the same post, within X minutes it only sends you one?
 
Have upgraded to newest version of Alert Improvements. When clicking page 2 of alerts I have a user seeing an error. Page 2 works for me and nothing showing in ACP under errors.

198185
 
It's a live site I can't show the debug info to all users? My account is not showing a problem with alerts page 2, it's a users.
 
This looks like it may be related to Alert Improvements?

Code: 
Server error log
InvalidArgumentException: Accessed unknown getter 'sv_rating_type' on XF:UserAlert[779073] src/XF/Mvc/Entity/Entity.php:194
Generated by: trimmy Mar 20, 2019 at 12:27 PM
Stack trace
#0 src/XF/Mvc/Entity/Entity.php(106): XF\Mvc\Entity\Entity->get('sv_rating_type')
#1 internal_data/code_cache/templates/l1/s72/public/alert_conversation_message_rating.php(9): XF\Mvc\Entity\Entity->offsetGet('sv_rating_type')
#2 src/XF/Template/Templater.php(1301): XF\Template\Templater->{closure}(Object(SV\AlertImprovements\XF\Template\Templater), Array)
#3 src/XF/Alert/AbstractHandler.php(80): XF\Template\Templater->renderTemplate('alert_conversat...', Array)
#4 src/XF/Entity/UserAlert.php(69): XF\Alert\AbstractHandler->render(Object(SV\AlertImprovements\XF\Entity\UserAlert))
#5 [internal function]: XF\Entity\UserAlert->render()
#6 src/XF/Template/Templater.php(985): call_user_func_array(Array, Array)
#7 internal_data/code_cache/templates/l1/s72/public/alert_macros.php(42): XF\Template\Templater->method(Object(SV\AlertImprovements\XF\Entity\UserAlert), 'render', Array)
#8 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(SV\AlertImprovements\XF\Template\Templater), Array, Array)
#9 internal_data/code_cache/templates/l1/s72/public/account_alerts_popup.php(18): XF\Template\Templater->callMacro('alert_macros', 'row', Array, Array)
#10 src/XF/Template/Templater.php(1301): XF\Template\Templater->{closure}(Object(SV\AlertImprovements\XF\Template\Templater), Array)
#11 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('account_alerts_...', Array)
#12 src/XF/Mvc/Renderer/Json.php(84): XF\Template\Template->render()
#13 src/XF/Mvc/Renderer/Json.php(68): XF\Mvc\Renderer\Json->renderHtmlFallback('XF:Account\\Aler...', 'public:account_...', Array)
#14 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Json->renderView('XF:Account\\Aler...', 'public:account_...', Array)
#15 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#16 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#17 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#18 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#19 src/XF.php(390): XF\App->run()
#20 index.php(20): XF::runApp('XF\\Pub\\App')
#21 {main}
Request state
array(4) {
  ["url"] => string(157) "/account/alerts-popup?_xfRequestUri=%2Fwhats-new%2F&_xfWithData=1&_xfToken=1553084842%2Cb89f76b23bc4bf95bdf905d962bc500d&_xfResponseType=json&_=1553084842474"
  ["referrer"] => string(36) "https://cafesaxophone.com/whats-new/"
  ["_GET"] => array(5) {
    ["_xfRequestUri"] => string(11) "/whats-new/"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(43) "1553084842,b89f76b23bc4bf95bdf905d962bc500d"
    ["_xfResponseType"] => string(4) "json"
    ["_"] => string(13) "1553084842474"
  }
  ["_POST"] => array(0) {
  }
}
 
@Mr Lucky that is related to Content Rating being disabled but not uninstalled, there is SQL instructions in that add's thread on how to fix that error
 
  • TypeError: Argument 5 passed to XF\Template\Templater::fnLink() must be of the type array, string given
  • src/XF/Template/Templater.php:2638
  • Generated by:
  • Apr 16, 2019 at 6:05 PM
Stack trace

#0 [internal function]: XF\Template\Templater->fnLink(Object(SV\AlertImprovements\XF\Template\Templater), true, 'reports/comment', Object(SV\ReportImprovements\XF\Entity\ReportComment), 'report_comment_...')
#1 src/XF/Template/Templater.php(922): call_user_func_array(Array, Array)
#2 internal_data/code_cache/templates/l1/s9/public/alert_report_comment_like_summary.php(6): XF\Template\Templater->fn('link', Array, true)
#3 src/XF/Template/Templater.php(1301): XF\Template\Templater->{closure}(Object(SV\AlertImprovements\XF\Template\Templater), Array)
#4 src/XF/Alert/AbstractHandler.php(80): XF\Template\Templater->renderTemplate('alert_report_co...', Array)
#5 src/XF/Entity/UserAlert.php(69): XF\Alert\AbstractHandler->render(Object(SV\AlertImprovements\XF\Entity\UserAlert))
#6 [internal function]: XF\Entity\UserAlert->render()
#7 src/XF/Template/Templater.php(985): call_user_func_array(Array, Array)
#8 internal_data/code_cache/templates/l1/s9/public/alert_macros.php(42): XF\Template\Templater->method(Object(SV\AlertImprovements\XF\Entity\UserAlert), 'render', Array)
#9 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(SV\AlertImprovements\XF\Template\Templater), Array, Array)
#10 internal_data/code_cache/templates/l1/s9/public/account_alerts_popup.php(18): XF\Template\Templater->callMacro('alert_macros', 'row', Array, Array)
#11 src/XF/Template/Templater.php(1301): XF\Template\Templater->{closure}(Object(SV\AlertImprovements\XF\Template\Templater), Array)
#12 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('account_alerts_...', Array)
#13 src/XF/Mvc/Renderer/Json.php(84): XF\Template\Template->render()
#14 src/XF/Mvc/Renderer/Json.php(68): XF\Mvc\Renderer\Json->renderHtmlFallback('XF:Account\\Aler...', 'public:account_...', Array)
#15 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Json->renderView('XF:Account\\Aler...', 'public:account_...', Array)
#16 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#17 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#18 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#19 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#20 src/XF.php(390): XF\App->run()
#21 index.php(20): XF::runApp('XF\\Pub\\App')
#22 {main}

Request state

array(4) {
["url"] => string(163) "/account/alerts-popup?xfRequestUri=%2Freports%2F42765%2F&_xfWithData=1&_xfToken=1555463142%2Cb093503f19b548c3af754db63be02004&_xfResponseType=json&=1555463142121"
["referrer"] => string(37) "https://net/reports/42765/"
["_GET"] => array(5) {
["_xfRequestUri"] => string(15) "/reports/42765/"
["_xfWithData"] => string(1) "1"
["_xfToken"] => string(43) "1555463142,b093503f19b548c3af754db63be02004"
["_xfResponseType"] => string(4) "json"
["_"] => string(13) "1555463142121"
}
["_POST"] => array(0) {
}
}
Click to expand...
F9E1E2CC-C379-4BCB-9FF6-B313E3C84828.webp
 
dethfire said:
Can you explain what we're supposed to experience here. I'm not sure I understand or notice any difference.
Click to expand...
There is a global option to list unread alerts, then read alerts which makes much much more sense given this add-on lets you very easily view them out of order, and hunting through your alert pop-up list for unread alerts is a ****ing pain.

Then there is a per-user option to clicking the 'alerts' pop-up and it doesn't mark all the alerts as read.
 
@Xon, would/should this summarize trophy alerts? I had a recent issue where running the rebuild trophy points task resulted in some members getting slammed with trophy alerts. In my ACP I have the summarization options enabled to group alerts. Should the users have gotten a single summary alert for all of the trophies they just got or a single summary alert?

Thanks

201146
 
You must log in or register to reply here.

Similar threads

N
Conversation Improvements by Xon - FRENCH translation
Replies
2
Views
538
Ozzy47
Ozzy47
N
Report Improvements by Xon - FRENCH translation
Replies
4
Views
531
Ozzy47
Ozzy47
N
Warning Improvements by Xon - FRENCH translation
Replies
3
Views
552
Ozzy47
Ozzy47
N
User Mentions Improvements by Xon - FRENCH translation
Replies
2
Views
517
Ozzy47
Ozzy47
N
Search Improvements by Xon - FRENCH translation
Replies
6
Views
648
Ozzy47
Ozzy47
Top Bottom