Ads Manager 2 by Siropu

Ads Manager 2 by Siropu [Paid] 2.8.1

No permission to buy (€50.00)
Overview FAQ Updates (99) Reviews (47) History Discussion
Yes, there is. You can even set user group permissions to bypass ad approval.
 
Error on install (upgrade from xf1 version) this last one version (beta 5).
I have legacy version installed (disabled) from xf1.
This is my first attempt to install version for xf2

Code: 
ErrorException: [E_WARNING] fopen(/home/nginx/domains/pijanitvor.com/public/data/siropu/am/package/58c803530030c.png): failed to open stream: Permission denied in src/vendor/league/flysystem/src/Adapter/Local.php at line 151
XF::handlePhpError()
fopen() in src/vendor/league/flysystem/src/Adapter/Local.php at line 151
League\Flysystem\Adapter\Local->writeStream() in src/vendor/league/flysystem/src/Filesystem.php at line 121
League\Flysystem\Filesystem->putStream()
call_user_func_array() in src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php at line 431
League\Flysystem\EventableFilesystem\EventableFilesystem->callFilesystemMethod() in src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php at line 395
League\Flysystem\EventableFilesystem\EventableFilesystem->delegateMethodCall() in src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php at line 71
League\Flysystem\EventableFilesystem\EventableFilesystem->putStream()
call_user_func_array() in src/vendor/league/flysystem/src/MountManager.php at line 269
League\Flysystem\MountManager->invokePluginOnFilesystem() in src/vendor/league/flysystem/src/MountManager.php at line 179
League\Flysystem\MountManager->__call() in src/XF/Util/File.php at line 101
XF\Util\File::copyFileToAbstractedPath() in src/addons/Siropu/AdsManager/Setup.php at line 145
Siropu\AdsManager\Setup->upgrade2000035Step2() in src/XF/AddOn/StepRunnerUpgradeTrait.php at line 122
Siropu\AdsManager\Setup->upgradeStepRunner() in src/XF/AddOn/StepRunnerUpgradeTrait.php at line 71
Siropu\AdsManager\Setup->upgrade() in src/XF/Admin/Controller/AddOn.php at line 437
XF\Admin\Controller\AddOn->actionUpgrade() in src/XF/Mvc/Dispatcher.php at line 249
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1889
XF\App->run() in src/XF.php at line 328
XF::runApp() in admin.php at line 13

Tried to upgrade second time and it worked. Seems that addon is upgraded OK.
But..
This I get every time (tons of this) I open list Ads manager link in acp (/admin.php?ads-manager/ads/)


Code: 
Server error log
ErrorException: Template error: Cannot call method isXfItem on a non-object (NULL) src/XF/Template/Templater.php:923
Generated by: Sunka 05.03.2018. at 02:28
Stack trace
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Cannot call met...', '/home/nginx/dom...', 923, Array)
#1 src/XF/Template/Templater.php(923): trigger_error('Cannot call met...', 512)
#2 internal_data/code_cache/templates/l1/s0/admin/siropu_ads_manager_ad_list.php(155): XF\Template\Templater->method(NULL, 'isXfItem', Array)
#3 src/XF/Template/Templater.php(1246): XF\Template\Templater->{closure}(Object(SV\ContentRatings\XF\Template\Templater), Array)
#4 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('siropu_ads_mana...', Array)
#5 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#6 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('Siropu\\AdsManag...', 'admin:siropu_ad...', Array)
#7 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#8 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#9 src/XF/App.php(1889): XF\Mvc\Dispatcher->run()
#10 src/XF.php(328): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}
Request state
array(4) {
  ["url"] => string(27) "/admin.php?ads-manager/ads/"
  ["referrer"] => string(45) "https://www.pijanitvor.com/admin.php?add-ons/"
  ["_GET"] => array(1) {
    ["ads-manager/ads/"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}


@Siropu - Did upgrade to xf2 version delete old files from xf1 version or I should delete orphan files somewhere?
Any chance to move Addon option in ACP (left main sidebar) more bellow because it is first on list, above Default Setup?
 
Also

Code: 
Server error log
ErrorException: Template error: Cannot call method getTypePhrase on a non-object (NULL) src/XF/Template/Templater.php:923
Generated by: Sunka 05.03.2018. at 03:29
Stack trace
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Cannot call met...', '/home/nginx/dom...', 923, Array)
#1 src/XF/Template/Templater.php(923): trigger_error('Cannot call met...', 512)
#2 internal_data/code_cache/templates/l1/s0/admin/siropu_ads_manager_ad_list.php(177): XF\Template\Templater->method(NULL, 'getTypePhrase', Array)
#3 src/XF/Template/Templater.php(1246): XF\Template\Templater->{closure}(Object(SV\ContentRatings\XF\Template\Templater), Array)
#4 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('siropu_ads_mana...', Array)
#5 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#6 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('Siropu\\AdsManag...', 'admin:siropu_ad...', Array)
#7 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#8 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#9 src/XF/App.php(1889): XF\Mvc\Dispatcher->run()
#10 src/XF.php(328): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}
Request state
array(4) {
  ["url"] => string(27) "/admin.php?ads-manager/ads/"
  ["referrer"] => string(61) "https://www.pijanitvor.com/admin.php?ads-manager/ads/135/edit"
  ["_GET"] => array(1) {
    ["ads-manager/ads/"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}
 
The first error is because a folder permission issue and the second and third because of the first error, package failed to convert. If you have ads that are assign to a "invisible" package, edit them and unset that package.
 
Adsense is not showing.
Ad is active, the user permissions are ok and i have selected just header for test.
Nothing shows up.
 
Siropu said:
Sent you a PM.


It's a unit width issue, will be fixed in the next release. Take a look in the browser console, you should see an adsense error.
Click to expand...
Ok, on mobile it works well.
Just not on desktop
 
Robby said:
Adsense is not showing.
Ad is active, the user permissions are ok and i have selected just header for test.
Nothing shows up.
Click to expand...
Robby said:
Ok, on mobile it works well.
Just not on desktop
Click to expand...
Siropu said:
It's a unit width issue, will be fixed in the next release. Take a look in the browser console, you should see an adsense error.
Click to expand...

Same here.
Any eta for this new release with working adsense?
 
Please try the following.

Go to siropu_ads_manager_ad.less template and remove this line:
CSS: 
.samItem
{
    display: inline-block;
}
 
If adsense code alignment set to center or right, it not showing.
Auto and left working
 
Indeed there is a problem with the ads, I can see it from my earnings after upgrade, it dropped 80%.
 
@Siropu

Already did, sometimes it shows sometimes it doesn't, most of the time it doesn't. So it's a loss.

I was thinking maybe Adsense doesn't have ads to show LOL, so I set up an add with the advertising option from Xenforo and it shows every refresh an ad from Google, so for sure, there is a problem with the ad manager when using Adsense codes.

After this, I said let me try create a banner ad and put the code in the "CUSTOM HTML" box, however, when try to create the ad it says no banner image + link provided. Basically this option not even working.

You need to fix this as soon as you can. Regards.
 
You must log in or register to reply here.

Similar threads

cloudpro
Custom CSS - Siropu Ads Manager
Replies
6
Views
437
DohTheme
DohTheme
D
Ads Manager 2 by Siropu - FRENCH translation [Deleted]
Replies
3
Views
746
Ozzy47
Ozzy47
AndyB
Auto ads manager [Paid]
Replies
2
Views
641
AndyB
AndyB
D
Chat 2 by Siropu - FRENCH translation [Deleted]
Replies
4
Views
806
Ozzy47
Ozzy47
Siropu
Donations by Siropu [Paid]
14 15 16
Replies
318
Views
14K
Siropu
Siropu
Back
Top Bottom